Overrides for tags and run_tags

[guikcd]

Summary

Support tags and/or run_tags in overrides.auto.pkrvars.hcl:

tags = {
  owner = "myteam"
  environment= "test"
}

run_tags = {
  owner = "packer"
  environment= "build"
}

Before this PR, users need to identity AMI and manually tags the resulted AMI.

Closes: #31

Implementation details

Define a variable for tags and run_tags for overrides

Then for each variant:

• tags are moved into locals as default_tags
• merge the default + user provided tags and define tags
• define run_tags

Testing

Building AMIs without overriding these tags are OK
Building AMIs with these tags are OK:

ALL=$(ls al*|sed "s/.pkr.hcl//")

for variant in $ALL
do
        rm -f manifest.json
        REGION=eu-west-1 make ${variant}
        ami=$(jq -r ".builds[0].artifact_id" manifest.json | awk -F':' '{print $NF}')
        # tags are set when AMI is available, not during creation
        echo "wait AMI"
        aws ec2 wait image-available --image-ids $ami
        snap=$(aws ec2 describe-images --region eu-west-1 --image-ids $ami --query "Images[0].BlockDeviceMappings[0].Ebs.SnapshotId" --output text)
        echo "check tags"
        aws ec2 describe-images --region eu-west-1 --image-ids $ami --query "Images[0].Tags[]" --output text | grep --quiet "myteam"
        if [ $? -ne 0 ]
        then
                echo "WARNING: tags are not set! for $variant / $ami"
        fi
        echo "unregister"
        aws ec2 deregister-image --image-id $ami
        echo "delete snap"
        aws ec2 delete-snapshot --snapshot-id $snap
done

New tests cover the changes: yes

Description for the changelog

Feature: Support user provided tags and run_tags.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[danehlim]

Hi @guikcd, thank you for opening this pull request! I have left a few minor comments/clarifying questions.

[guikcd]

I've fixed my errors.
I can't test the whole build of all images because of (ex.: variant al2023neu):

==> amazon-ebs.al2023neu: Provisioning with shell script: scripts/install-ecs-init.sh
==> amazon-ebs.al2023neu: + '[' -n '' ']'
==> amazon-ebs.al2023neu: + '[' -n '' ']'
==> amazon-ebs.al2023neu: ++ mktemp -d
==> amazon-ebs.al2023neu: + WORK_DIR=/tmp/tmp.JezVwldTwT
==> amazon-ebs.al2023neu: + trap 'rm -rf /tmp/tmp.JezVwldTwT' EXIT
==> amazon-ebs.al2023neu: + cat
==> amazon-ebs.al2023neu: + '[' -z '' ']'
==> amazon-ebs.al2023neu: ++ uname -m
==> amazon-ebs.al2023neu: + ARCH=x86_64
==> amazon-ebs.al2023neu: + host_suffix=
==> amazon-ebs.al2023neu: + grep -q '^cn-'
==> amazon-ebs.al2023neu: + ECS_INIT_URL=https://s3.eu-west-1.amazonaws.com/amazon-ecs-agent-eu-west-1/ecs-init-1.89.1-1.amzn2023.x86_64.rpm
==> amazon-ebs.al2023neu: + curl -fLSs -o /tmp/tmp.JezVwldTwT/ecs-init.rpm https://s3.eu-west-1.amazonaws.com/amazon-ecs-agent-eu-west-1/ecs-init-1.89.1-1.amzn2023.x86_64.rpm
==> amazon-ebs.al2023neu: curl: (22) The requested URL returned error: 403
==> amazon-ebs.al2023neu: + rm -rf /tmp/tmp.JezVwldTwT
==> amazon-ebs.al2023neu: Provisioning step had errors: Running the cleanup provisioner, if present...

The ecs-init is now archived and migrated to ecs-agent since September: https://github.com/aws/amazon-ecs-init

agent version for ecs-init is now latest: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-agent-install.html

$ curl -I https://s3.eu-west-1.amazonaws.com/amazon-ecs-agent-eu-west-1/ecs-init-1.89.1-1.amzn2023.x86_64.rpm
HTTP/1.1 403 Forbidden
x-amz-request-id: 59Q1NEEAATN7SJSE
x-amz-id-2: NNNwOxOgU5I/QHeJPs7WgRM9DK3fQaeuxxmMepd1zSQS/8iRZm16tOSMG9ML93j8AReefInE5h8=
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Tue, 03 Dec 2024 11:14:58 GMT
Server: AmazonS3

$ curl -I https://s3.eu-west-1.amazonaws.com/amazon-ecs-agent-eu-west-1/ecs-init-latest.amzn2023.x86_64.rpm
HTTP/1.1 200 OK
x-amz-id-2: wl32kmrVmlEv45MQsJZmI0s16etvCsgqg2pGg2f0VLE3nQ+/w3k/YgJtkLMfwV17pjQVWZTzPDY=
x-amz-request-id: TKVV1X4C95N1BF94
Date: Tue, 03 Dec 2024 11:15:12 GMT
Last-Modified: Thu, 07 Nov 2024 18:11:37 GMT
ETag: "9cd82e32980aececdcef48a9e028e9ca-4"
x-amz-server-side-encryption: AES256
Accept-Ranges: bytes
Content-Type: binary/octet-stream
Content-Length: 20734244
Server: AmazonS3

[danehlim]

Thanks @guikcd, the changes look good to me. I have approved this pull request.

The HTTP/1.1 403 Forbidden you are running into when trying to access https://s3.eu-west-1.amazonaws.com/amazon-ecs-agent-eu-west-1/ecs-init-1.89.1-1.amzn2023.x86_64.rpm is due to ecs-init-1.89.1-1 release still being ongoing at this time (it has not yet reached that bucket). Once that release is complete, it should be accessible.