-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AL2 kernel 5.10 GPU and INF #214
Conversation
0ded325
to
58f6e8b
Compare
58f6e8b
to
cddb996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Regarding the generate release note script, should we also include al2kerneldot10gpu
in these checks to ensure we're passing in a cuda + nvidia version?
amazon-ecs-ami/generate-release-notes.sh
Line 77 in ba5782d
if ! is_ami_excluded "al2gpu"; then |
Since we're not building/publishing these new AMI types yet, perhaps we should add a TODO somewhere
Good call out! Once ECS Agent team starts building and publishing these new AMI variants as part of the AMI release process, I will make sure to update the generate release notes script to factor in the new AMI variants. I will create an item to track this internally. |
Summary
Add new GPU and INF packer recipes using AL2 kernel 5.10.
Implementation details
al2kernel5dot10gpu.pkr.hcl
andal2kernel5dot10inf.pkr.hcl
al2.pkr.hcl
build sources to includeal2kernel5dot10gpu
andal2kernel5dot10inf
al2kernel5dot10gpu
andal2kernel5dot10inf
toMakefile
andREADME.md
AMI_TYPE
starts with "al2kernel5dot10"AMI_TYPE
starts with "al2" and ends with "gpu"AMI_TYPE
starts with "al2" and ends with "inf" (or is "al2023neu")Testing
✅ Successfully build AMIs using the new AMI recipes locally.
✅ Launch EC2 instances using the built AMIs.
✅ Confirm Linux kernel version 5.10 is enabled and running on the launched instances.
✅ Confirm kernel and kernel header packages installed in the RPM database are only for Linux kernel 5.10 on the launched instances.
✅ Run relevant GPU and INF functional tests against the built AMIs from manual testing steps above and ensure all tests pass.
✅ For the built GPU kernel 5.10 AMI, run testing steps from #163 against it and make sure they are successful. This is to ensure post-kepler NVIDIA open kernel module installation still behaves as expected.
Additional sanity checks
On EC2 instance launched using built GPU kernel 5.10 AMI:On EC2 instance launched using built INF kernel 5.10 AMI:
New tests cover the changes: N/A
Description for the changelog
Support AL2 kernel 5.10 GPU and INF
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.