Add generateConfig action, updates to check-update-security and generate-release-vars.sh #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainerd versions similar to previously existing release vars
hozkaya2000
changed the title
hozkaya2000
changed the title
sparrc
reviewed
Dec 5, 2023
sparrc
reviewed
Dec 5, 2023
amogh09
reviewed
Dec 5, 2023
hozkaya2000
force-pushed
the
feature/shinkansen
branch
2 times, most recently
from
6b744ea to
cc95faf
Compare
amogh09
reviewed
Dec 5, 2023
hozkaya2000
force-pushed
the
feature/shinkansen
branch
2 times, most recently
from
131136f to
c012d99
Compare
amogh09
reviewed
Dec 6, 2023
hozkaya2000
force-pushed
the
feature/shinkansen
branch
2 times, most recently
from
7e6ba2e to
f41e6f4
Compare
hozkaya2000
force-pushed
the
feature/shinkansen
branch
from
f41e6f4 to
1a69cf4
Compare
amogh09
approved these changes
Dec 6, 2023
sparrc
approved these changes
Dec 6, 2023
danehlim
pushed a commit
to danehlim/amazon-ecs-ami
that referenced
this pull request
Feb 6, 2024
…ate-release-vars.sh (aws#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security
danehlim
pushed a commit
to danehlim/amazon-ecs-ami
that referenced
this pull request
Feb 6, 2024
…ate-release-vars.sh (aws#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security
danehlim
added a commit
that referenced
this pull request
Feb 6, 2024
* Add action to push to codecommit mirror ripository * release.auto.pkvars.hcl refactor: creating 1 file per AMI variant * Add script to check for security update of given ami (#165) * Change generate-release-vars.sh to update specific release files (#169) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars (#173) * Add generateConfig action, updates to check-update-security and generate-release-vars.sh (#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security * Add security update install script in build recipe for al1 and al2 (#178) * Remove unnecessary security update checks for al2023 (#186) * Combine GenerateConfig and PushToCodeCommit actions under one action and add conditional kickoff (#187) * Refactor generate release notes script for enhanced release process --------- Co-authored-by: hozkaya2000 <[email protected]> Co-authored-by: Anuj Singh <[email protected]> Co-authored-by: hozkaya2000 <[email protected]>
rwarren25
pushed a commit
to rwarren25/amazon-ecs-ami
that referenced
this pull request
Jul 9, 2024
* Add action to push to codecommit mirror ripository * release.auto.pkvars.hcl refactor: creating 1 file per AMI variant * Add script to check for security update of given ami (aws#165) * Change generate-release-vars.sh to update specific release files (aws#169) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars (aws#173) * Add generateConfig action, updates to check-update-security and generate-release-vars.sh (aws#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security * Add security update install script in build recipe for al1 and al2 (aws#178) * Remove unnecessary security update checks for al2023 (aws#186) * Combine GenerateConfig and PushToCodeCommit actions under one action and add conditional kickoff (aws#187) * Refactor generate release notes script for enhanced release process --------- Co-authored-by: hozkaya2000 <[email protected]> Co-authored-by: Anuj Singh <[email protected]> Co-authored-by: hozkaya2000 <[email protected]>
rwarren25
pushed a commit
to rwarren25/amazon-ecs-ami
that referenced
this pull request
Jul 9, 2024
* Add action to push to codecommit mirror ripository * release.auto.pkvars.hcl refactor: creating 1 file per AMI variant * Add script to check for security update of given ami (aws#165) * Change generate-release-vars.sh to update specific release files (aws#169) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars (aws#173) * Add generateConfig action, updates to check-update-security and generate-release-vars.sh (aws#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security * Add security update install script in build recipe for al1 and al2 (aws#178) * Remove unnecessary security update checks for al2023 (aws#186) * Combine GenerateConfig and PushToCodeCommit actions under one action and add conditional kickoff (aws#187) * Refactor generate release notes script for enhanced release process --------- Co-authored-by: hozkaya2000 <[email protected]> Co-authored-by: Anuj Singh <[email protected]> Co-authored-by: hozkaya2000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add generate config github action. The action checks runs ./generate-release-vars.sh, sees if there are any dependency updates, and pushes to the repository in the case of a release needing to be kicked off. If no dependency updates exist, it will fall back to checking security updates by launching an ec2 instance with the AMIs and checking for critical updates.
Also includes a couple modifications to the check update security script to make it more resilient to API errors, that occurred in a couple rare test scenarios.
Implementation details
The action was split into steps of a github action, and runs on workflow dispatch as of now.
Testing
A testing document was made to check all important test scenarios.
New tests cover the changes: yes
Description for the changelog
Add GenerateConfig github action
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.