Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the enable inf support script #152

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

chienhanlin
Copy link
Contributor

@chienhanlin chienhanlin commented Oct 10, 2023

Summary

This PR removes a typo use from the enable-ecs-agent-inferentia-support.sh.

P.S. The associated PR is #149.

Implementation details

Remove a typo use from enable-ecs-agent-inferentia-support.sh.

Testing

  1. Build a new AL2023 NEU with the updated script, and confirm Neuron devices and with Neuron tools tests both pass.
==> amazon-ebs.al2023neu: + [[ al2023neu == \a\l\2\i\n\f ]]
==> amazon-ebs.al2023neu: + sudo yum install -y aws-neuronx-tools
    amazon-ebs.al2023neu: Last metadata expiration check: 0:02:18 ago on Tue Oct 10 17:02:47 2023.
    amazon-ebs.al2023neu: Dependencies resolved.
    amazon-ebs.al2023neu: ================================================================================
    amazon-ebs.al2023neu:  Package                  Architecture  Version             Repository     Size
    amazon-ebs.al2023neu: ================================================================================
    amazon-ebs.al2023neu: Installing:
    amazon-ebs.al2023neu:  aws-neuronx-tools        x86_64        2.14.6.0-1          neuron         28 M
    amazon-ebs.al2023neu:
    amazon-ebs.al2023neu: Transaction Summary
    amazon-ebs.al2023neu: ================================================================================
    amazon-ebs.al2023neu: Install  1 Package
    amazon-ebs.al2023neu:
    amazon-ebs.al2023neu: Total download size: 28 M
    amazon-ebs.al2023neu: Installed size: 97 M
    amazon-ebs.al2023neu: Downloading Packages:
    amazon-ebs.al2023neu: aws-neuronx-tools-2.14.6.0.rpm                   15 MB/s |  28 MB     00:01
    amazon-ebs.al2023neu: --------------------------------------------------------------------------------
    amazon-ebs.al2023neu: Total                                            15 MB/s |  28 MB     00:01
    amazon-ebs.al2023neu: Running transaction check
    amazon-ebs.al2023neu: Transaction check succeeded.
    amazon-ebs.al2023neu: Running transaction test
    amazon-ebs.al2023neu: Transaction test succeeded.
    amazon-ebs.al2023neu: Running transaction
    amazon-ebs.al2023neu:   Preparing        :                                                        1/1
    amazon-ebs.al2023neu:   Installing       : aws-neuronx-tools-2.14.6.0-1.x86_64                    1/1
    amazon-ebs.al2023neu:   Verifying        : aws-neuronx-tools-2.14.6.0-1.x86_64                    1/1
    amazon-ebs.al2023neu:
    amazon-ebs.al2023neu: Installed:
    amazon-ebs.al2023neu:   aws-neuronx-tools-2.14.6.0-1.x86_64
    amazon-ebs.al2023neu:
    amazon-ebs.al2023neu: Complete!
==> Builds finished. The artifacts of successful builds are:
--> amazon-ebs.al2023neu: AMIs were created:
ap-northeast-1: ami-xxx
  1. Built a new AL2 INF AMI with the updated script, and confirm Neuron devices and with Neuron tools tests both pass.
==> amazon-ebs.al2inf: + sudo yum install -y aws-neuronx-tools
    amazon-ebs.al2inf: Loaded plugins: dkms-build-requires, priorities, update-motd, upgrade-helper
    amazon-ebs.al2inf: Resolving Dependencies
    amazon-ebs.al2inf: --> Running transaction check
    amazon-ebs.al2inf: ---> Package aws-neuronx-tools.x86_64 0:2.14.6.0-1 will be installed
    amazon-ebs.al2inf: --> Finished Dependency Resolution
    amazon-ebs.al2inf:
    amazon-ebs.al2inf: Dependencies Resolved
    amazon-ebs.al2inf:
    amazon-ebs.al2inf: ================================================================================
    amazon-ebs.al2inf:  Package                  Arch          Version             Repository     Size
    amazon-ebs.al2inf: ================================================================================
    amazon-ebs.al2inf: Installing:
    amazon-ebs.al2inf:  aws-neuronx-tools        x86_64        2.14.6.0-1          neuron         28 M
    amazon-ebs.al2inf:
    amazon-ebs.al2inf: Transaction Summary
    amazon-ebs.al2inf: ================================================================================
    amazon-ebs.al2inf: Install  1 Package
    amazon-ebs.al2inf:
    amazon-ebs.al2inf: Total download size: 28 M
    amazon-ebs.al2inf: Installed size: 97 M
    amazon-ebs.al2inf: Downloading packages:
    amazon-ebs.al2inf: Running transaction check
    amazon-ebs.al2inf: Running transaction test
    amazon-ebs.al2inf: Transaction test succeeded
    amazon-ebs.al2inf: Running transaction
    amazon-ebs.al2inf:   Installing : aws-neuronx-tools-2.14.6.0-1.x86_64                          1/1
    amazon-ebs.al2inf:   Verifying  : aws-neuronx-tools-2.14.6.0-1.x86_64                          1/1
    amazon-ebs.al2inf:
    amazon-ebs.al2inf: Installed:
    amazon-ebs.al2inf:   aws-neuronx-tools.x86_64 0:2.14.6.0-1
    amazon-ebs.al2inf:
    amazon-ebs.al2inf: Complete!
--> amazon-ebs.al2inf: AMIs were created:
ap-northeast-1: xxx

New tests cover the changes: no

Description for the changelog

N/A

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chienhanlin chienhanlin changed the title Fix an incorrect package used in the enable inf support script Fix a typo in the enable inf support script Oct 10, 2023
@chienhanlin chienhanlin merged commit f8e9d67 into aws:main Oct 10, 2023
2 checks passed
@danehlim danehlim mentioned this pull request Oct 23, 2023
@singholt singholt mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants