Adding EnableFaultInjection to task payload #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishxr
force-pushed
the
fis-payload
branch
from
9ad1aa2 to
ba7e457
Compare
mye956
reviewed
Sep 25, 2024
mye956
reviewed
Sep 25, 2024
harishxr
changed the title
harishxr
changed the title
harishxr
force-pushed
the
fis-payload
branch
from
ba7e457 to
74c3067
Compare
amogh09
reviewed
Sep 25, 2024
| @@ -38,7 +38,7 @@ type TaskResponse struct { | |||
| EphemeralStorageMetrics *EphemeralStorageMetrics `json:"EphemeralStorageMetrics,omitempty"` | |||
| CredentialsID string `json:"-"` | |||
| TaskNetworkConfig *TaskNetworkConfig `json:"-"` | |||
| FaultInjectionEnabled bool `json:"-"` | |||
There was a problem hiding this comment.
I think the current name is intentional.
There was a problem hiding this comment.
we have a change for this field in the feature branch
There was a problem hiding this comment.
Perhaps we should add a comment either in the PR description or in the code denoting that EnabledFaultInjection within the Task struct of agent/api/task essentially relates/maps to FaultInjectionEnabled within the task response struct of ecs-agent/tmds/handlers/v4/state/
harishxr
force-pushed
the
fis-payload
branch
2 times, most recently
from
98dba89 to
553903c
Compare
amogh09
reviewed
Sep 25, 2024
harishxr
force-pushed
the
fis-payload
branch
2 times, most recently
from
19fad6a to
1d123a7
Compare
amogh09
approved these changes
Sep 26, 2024
mye956
approved these changes
Sep 26, 2024
harishxr
force-pushed
the
fis-payload
branch
from
1d123a7 to
dab3142
Compare
harishxr
force-pushed
the
fis-payload
branch
from
dab3142 to
069246e
Compare
mye956
pushed a commit
to mye956/amazon-ecs-agent
that referenced
this pull request
Oct 3, 2024
Co-authored-by: Harish Senthilkumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds
EnableFaultInjectionto the task payload.Implementation details
EnableFaultInjectioninto the task struct.EnableFaultInjectionfield to true in the task struct when the corresponding AcsTask is not nil.Testing
Ran the existing set of tests to verify the change to
EnableFaultInjectionDescription for the changelog
Adding EnableFaultInjection to task payload
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.