Adding os/exec wrapper for testability #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
reviewed
Aug 29, 2024
Comment on lines
+43
to
+58
| type cmdWrapper struct { | ||
| *exec.Cmd | ||
| } |
There was a problem hiding this comment.
Why do we need to create this new struct? Shouldn't exec.Cmd already implement Cmd interface?
There was a problem hiding this comment.
The cmdWrapper interface is not exactly the same, we also added a couple helper functions to help with common used functionalities such as SetIOStreams(). Without having this extra struct, we won't be able to make the helper functions non-static (we would get error cannot define new methods on non-local type exec.Cmd)
xxx0624
reviewed
Aug 29, 2024
| @@ -0,0 +1,91 @@ | |||
| package execwrapper | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
+1, ditto in the mocks as well (ref)
xxx0624
previously approved these changes
Sep 3, 2024
xxx0624
approved these changes
Sep 4, 2024
mye956
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a wrapper for
os/execso that we can add mock for the fault injection features that use linuxtcImplementation details
A new interface
Cmdis added, which wraps around several features ofos/execTesting
go generatewas ran to create the mock file and passed.Description for the changelog
Adding wrapper and mock for
os/execAdditional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.