Fix flakey TestManifestPulledDoesNotDependOnContainerOrdering integration test

[tinnywang]

Summary

Fix flakey TestManifestPulledDoesNotDependOnContainerOrdering integration test.

--- FAIL: TestManifestPulledDoesNotDependOnContainerOrdering (23.82s)
    --- FAIL: TestManifestPulledDoesNotDependOnContainerOrdering/0 (6.14s)
        engine_integ_test.go:650: 
            	Error Trace:	/opt/amazon-ecs-agent/go/src/github.com/aws/amazon-ecs-agent/agent/engine/engine_integ_test.go:650
            	Error:      	Not equal: 
            	            	expected: 4
            	            	actual  : 6
            	Test:       	TestManifestPulledDoesNotDependOnContainerOrdering/0

The test runs a task with two containers and asserts that the first container is in the RUNNING state. Occasionally, the first container exits and enters the STOPPED state before the assertion is made, so the test fails.

amazon-ecs-agent/agent/engine/engine_integ_test.go

Lines 622 to 623 in 6e5e459

	first := createTestContainerWithImageAndName(testRegistryImage, "first")
	first.Command = []string{"sh", "-c", "sleep 60"}

The container appears to run for 60 seconds, but it actually dies almost immediately after starting because it's using our netkitten image, which does not accept sh -c "sleep 60" as its command.

Reproducing this locally yields

> make netkitten
> docker run amazon/amazon-ecs-netkitten:make sh -c "sleep 60"
2024/08/20 00:40:42 Error connecting to target: dial tcp: address sh: missing port in address

Implementation details

Change the container command to -loop=true, which will keep the container running indefinitely until it's told to stop.

amazon-ecs-agent/agent/engine/common_unix_integ_testutil.go

Lines 35 to 39 in 6e5e459

	// GetLongRunningCommand returns the command that keeps the container running for the container
	// that uses the default integ test image (amazon/amazon-ecs-netkitten for unix)
	func GetLongRunningCommand() []string {
	return []string{"-loop=true"}
	}

Testing

Ran the flakey test 50 times and it completed successfully.

go test -tags integration ./agent/engine -count 50 -v -run TestManifestPulledDoesNotDependOnContainerOrdering

New tests cover the changes: no

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.