Added the fixes for Windows detected during internal testing. #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhc123
force-pushed
the
ebsTA-windows-bug-fixes
branch
9 times, most recently
from
9b5d76f to
546f4b0
Compare
saurabhc123
force-pushed
the
ebsTA-windows-bug-fixes
branch
from
546f4b0 to
e5be435
Compare
|
Changes LGTM |
mye956
reviewed
Aug 27, 2024
| ) | ||
|
|
||
| // IsBlockDevice checks if the given path is a block device on Windows. | ||
| func IsBlockDevice(fullPath string) (bool, error) { | ||
| // Ensure the fullPath ends with a backslash. | ||
|
|
||
| // We will parse only the taskID_VolumeID string. And example is: |
There was a problem hiding this comment.
nit(non-blocking): typo in And
mye956
reviewed
Aug 27, 2024
| @@ -166,3 +174,168 @@ func TestServiceConnectWithDisabledMetrics(t *testing.T) { | |||
| assert.Len(t, engine.tasksToHealthCheckContainers, 1) | |||
| assert.Len(t, engine.taskToServiceConnectStats, 1) | |||
| } | |||
|
|
|||
| // This test has been moved to be run Linux only. For Windows, the publish metrics timeout has been set to be 5 seconds | |||
There was a problem hiding this comment.
nit(non-blocking): the beginning sentence of the comment might be a bit misleading without full context for future references. Might just be better to just keep Note: For windows,....
mye956
approved these changes
Aug 27, 2024
Yiyuanzzz
approved these changes
Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the fixes to the volume metrics fetcher in the agent flows and in the CSI Driver for Windows.
Implementation details
Testing
We ran the integration in a Windows environment and validated the working of the metrics fetch.
New tests cover the changes: No. The existing tests were used to test this.
Description for the changelog
Added the fixes for Windows detected during internal testing.
Additional Information
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.