-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move instance credentials to shared library #3978
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.24+incompatible to 24.0.6+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.24...v24.0.6) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Bump github.com/docker/docker from 20.10.24+incompatible to 24.0.6+incompatible in /agent update docker version in /ecs-agent
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
Added the network builder and platform APIs into the shared library package. Network builder is intended to act as the API to be consumed by the agent to setup networking resources on the host. Network builder invokes the platform APIs to execute platform specific operations like creation of network namespaces etc. --------- Co-authored-by: Samuel Konat <[email protected]>
timj-hh
force-pushed
the
fe_credentials
branch
from
October 23, 2023 21:00
6ba4303
to
0a2fcc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change moves remaining credentials module after [this pull request] to the shared library. This is needed for ECS frontend, EC2 client, ECR factory. Usages in
agent/
have been accordingly updated.Implementation details
agent/credentials/instancecreds
toecs-agent/credentials/instancecreds
andagent/credentials/providers
toecs-agent/credentials/providers
seelog
tologger
go mod init && go mod vendor
ran inecs-agent
andagent
directories includingaws-vpc-cni-plugins
among other things.amazon-ecs-agent/ecs-agent/credentials
now looks like:Testing
make test
andmake run-integ-tests
New tests cover the changes: no (existing tests pass)
Description for the changelog
Move instance credentials and credential provider to shared library
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.