Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecs-agent external library for EBS-backed task support #3945

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mye956
Copy link
Contributor

@mye956 mye956 commented Oct 3, 2023

Summary

This PR will mainly pull in changes and fixes to the ecs-agent directory as part of EBS-backed task support. This is a per-requisite PR for #3929.

Note: In a follow up PR, we'll need to fix the watcher unit tests.

Implementation details

  • Changing/Fixing the attachment property keys and attachment type for attachment + task payload for EBS-backed tasks
  • Watcher fix: We'll now only be validating by Volume ID and will be returning the corresponding host device name. If the volume ID can't be found on the host then we'll return an error.

Testing

Unit test

New tests cover the changes:

Description for the changelog

Does this PR include breaking model changes? If so, Have you added transformation functions?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mye956 mye956 force-pushed the updateEbsShared branch 3 times, most recently from d0db18e to 05b4b94 Compare October 3, 2023 20:34
@mye956 mye956 marked this pull request as ready for review October 3, 2023 21:20
@mye956 mye956 requested a review from a team as a code owner October 3, 2023 21:20
@mye956 mye956 changed the title WIP Add ecs-agent external library WIP Update ecs-agent external library for EBS-backed task support Oct 3, 2023
@mye956 mye956 changed the title WIP Update ecs-agent external library for EBS-backed task support Update ecs-agent external library for EBS-backed task support Oct 3, 2023
@mye956 mye956 added the bot/test label Oct 3, 2023
Copy link
Member

@fierlion fierlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice neat changes

@mye956 mye956 added the bot/test label Oct 4, 2023
@mye956 mye956 merged commit 0f63b6e into aws:dev Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants