Skip to content

Commit

Permalink
increase timeouts for tests flaking on windows2019
Browse files Browse the repository at this point in the history
  • Loading branch information
tinnywang committed Aug 27, 2024
1 parent 68d2ec4 commit a64dbf2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion agent/engine/engine_windows_integ_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ func TestExecCommandAgent(t *testing.T) {
taskUpdate.SetDesiredStatus(apitaskstatus.TaskStopped)
go taskEngine.AddTask(taskUpdate)

ctx, cancel = context.WithTimeout(context.Background(), time.Second*20)
ctx, cancel = context.WithTimeout(context.Background(), time.Second*30)
go func() {
VerifyTaskIsStopped(stateChangeEvents, testTask)
cancel()
Expand Down
5 changes: 2 additions & 3 deletions agent/engine/ordering_integ_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
"github.com/stretchr/testify/assert"
)

const orderingTimeout = 90 * time.Second
const orderingTimeout = 120 * time.Second

// TestDependencyHealthCheck is a happy-case integration test that considers a workflow with a HEALTHY dependency
// condition. We ensure that the task can be both started and stopped.
Expand Down Expand Up @@ -478,7 +478,6 @@ func TestShutdownOrder(t *testing.T) {
t.Skip()
}

shutdownOrderingTimeout := 120 * time.Second
taskEngine, done, _, _ := setupWithDefaultConfig(t)
defer done()

Expand Down Expand Up @@ -569,7 +568,7 @@ func TestShutdownOrder(t *testing.T) {
close(finished)
}()

waitFinished(t, finished, shutdownOrderingTimeout)
waitFinished(t, finished, orderingTimeout)
}

func TestMultipleContainerDependency(t *testing.T) {
Expand Down

0 comments on commit a64dbf2

Please sign in to comment.