Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suspending/Resuming ASG Processes to ELBv2 #74

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

tgroshon
Copy link

The ELBv2 example scripts do not support suspending and resuming troublesome ASG
processes but the original ELB scripts do.

Update the ELBv2 common_functions.sh file to add this functionality.

  • Add a HANDLE_PROCS variable that denotes whether to suspend processes;
    defaults to false
  • Add a FLAGFILE implementation to keep track of which processes were suspended
    during the deploy and should be resumed
  • Update ASG decrementing to use the FLAGFILE instead of the single 'flag
    file'
  • Update the README.md to explain the ASG process suspension use case

Fixes Issue #53

The ELBv2 example scripts do not support suspending and resuming troublesome ASG
processes but the original ELB scripts do.

Update the ELBv2 `common_functions.sh` file to add this functionality.

 - Add a `HANDLE_PROCS` variable that denotes whether to suspend processes;
   defaults to false
 - Add a FLAGFILE implementation to keep track of which processes were suspended
   during the deploy and should be resumed
 - Update ASG decrementing to use the FLAGFILE instead of the single 'flag
   file'
 - Update the `README.md` to explain the ASG process suspension use case

Fixes Issue aws-samples#53
@tgroshon tgroshon changed the title Add Suspending/Resuming ASG Processes to ESBv2 Add Suspending/Resuming ASG Processes to ELBv2 Sep 11, 2017
Copy link

@avalent avalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, thanks for the contribution. Are you okay with this being released under the Apache License Version 2.0?

@tgroshon
Copy link
Author

@avalent yessir, Apache v2.0 is good with me 😄

@feverLu feverLu merged commit 37b3be0 into aws-samples:master Sep 14, 2017
@tgroshon
Copy link
Author

Thanks you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants