Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELBv2 examples don't include suspending or resuming ASG processes #53

Closed
nwalke opened this issue Sep 13, 2016 · 7 comments
Closed

ELBv2 examples don't include suspending or resuming ASG processes #53

nwalke opened this issue Sep 13, 2016 · 7 comments
Labels
enhancement

Comments

@nwalke
Copy link
Contributor

nwalke commented Sep 13, 2016

The ELB example has been updated to suspend/resume ASG processes. The ELBv2 examples should include these as well.
@Jmcfar
Copy link
Contributor

Jmcfar commented Oct 13, 2016

Hi,

Thanks for the feedback! I'll pass this along to the team to add to the scripts.

@schmohlio
Copy link

schmohlio commented Apr 20, 2017 •
edited
Loading

Is there an ETA on this?

Is it a fair temporary workaround to disable dynamic autoscaling on the ASG group (scale up/down manually)?

@eddca
Copy link

eddca commented Jul 21, 2017

I am waiting for this feature for a really long time.

Things get out of control when we don't suspend ASG.

Any ETA, guys?

@kgorskowski
Copy link

kgorskowski commented Jul 25, 2017 •
edited
Loading

Grew tired of waiting, hacked together a Lambda function to recreate a similar solution as long as the ELBv2 doesn't integrate with CodeDeploy. If anyone is interested, here is my Repository
(PS as of now it doesn't solve #70 but it should be fairly easy to implement asg minsize/desired etc into the script)

  • Just FYI: The Lambda function is now "in production" in our environment. You need to tag your autoscaling group accordingly to the deployment group and you can set the minsize of the ASG also with a tag. Lambda will then reset the Value to the value of the Tag whenever a deployment finishes, stops or fails.

tgroshon pushed a commit to tgroshon/aws-codedeploy-samples that referenced this issue Sep 11, 2017
Add Suspending/Resuming ASG Processes to ESBv2
c7b95e6 
The ELBv2 example scripts do not support suspending and resuming troublesome ASG
processes but the original ELB scripts do.

Update the ELBv2 `common_functions.sh` file to add this functionality.

 - Add a `HANDLE_PROCS` variable that denotes whether to suspend processes;
   defaults to false
 - Add a FLAGFILE implementation to keep track of which processes were suspended
   during the deploy and should be resumed
 - Update ASG decrementing to use the FLAGFILE instead of the single 'flag
   file'

Fixes Issue aws-samples#53
tgroshon pushed a commit to tgroshon/aws-codedeploy-samples that referenced this issue Sep 11, 2017
Add Suspending/Resuming ASG Processes to ESBv2
b094c6d 
The ELBv2 example scripts do not support suspending and resuming troublesome ASG
processes but the original ELB scripts do.

Update the ELBv2 `common_functions.sh` file to add this functionality.

 - Add a `HANDLE_PROCS` variable that denotes whether to suspend processes;
   defaults to false
 - Add a FLAGFILE implementation to keep track of which processes were suspended
   during the deploy and should be resumed
 - Update ASG decrementing to use the FLAGFILE instead of the single 'flag
   file'
 - Update the `README.md` to explain the ASG process suspension use case

Fixes Issue aws-samples#53
@tgroshon tgroshon mentioned this issue Sep 11, 2017
Merged
tgroshon pushed a commit to tgroshon/aws-codedeploy-samples that referenced this issue Sep 11, 2017
Add Suspending/Resuming ASG Processes to ELBv2
a5f7713 
The ELBv2 example scripts do not support suspending and resuming troublesome ASG
processes but the original ELB scripts do.

Update the ELBv2 `common_functions.sh` file to add this functionality.

 - Add a `HANDLE_PROCS` variable that denotes whether to suspend processes;
   defaults to false
 - Add a FLAGFILE implementation to keep track of which processes were suspended
   during the deploy and should be resumed
 - Update ASG decrementing to use the FLAGFILE instead of the single 'flag
   file'
 - Update the `README.md` to explain the ASG process suspension use case

Fixes Issue aws-samples#53
@tgroshon
Copy link

I just made a pull request which adds this feature in the same way that the ELB sample scripts do.

@tgroshon
Copy link

@Jmcfar Can you ask the team to take a look at that PR and let me know if I missed anything?

@tgroshon
Copy link

This can be closed now 🎉

@feverLu feverLu closed this as completed Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@nwalke @tgroshon @schmohlio @eddca @Jmcfar @feverLu @kgorskowski