chore: Adding Validation step for IaC with SAM #1498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rget compatibility
… Kotlin examples.
…tests too and is more idiomatic and readme to be more descriptive
…rget compatibility
… Kotlin examples.
…tests too and is more idiomatic and readme to be more descriptive
jasoniharris
changed the title
jeromevdl
reviewed
Oct 31, 2023
jeromevdl
reviewed
Oct 31, 2023
jeromevdl
changed the title
jeromevdl
approved these changes
Nov 10, 2023
|
@jasoniharris is there anything else? it's still in draft... |
|
@jasoniharris - build failing - if this gets too fiddly, suggest rebranching in the repo itself, as the builds will run automatically then. |
|
@jasoniharris, would you open another PR with a "local" branch? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Raised this branch instead - Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Issue #, if available: #1459 **
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.