-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws organizations account idempotency #90
Aws organizations account idempotency #90
Conversation
@@ -21,6 +21,8 @@ public void setCurrentRetryAttempt(final AccountConstants.Action actionName, fin | |||
} | |||
// used in CREATE handler | |||
private boolean isAccountCreated = false; | |||
private boolean isPreExistenceCheckComplete = false; | |||
private boolean isDidResourceAlreadyExist = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isDidResourceAlreadyExist
-> didResourceAlreadyExist
Without this update, will isDidResourceAlreadyExist
and setDidResourceAlreadyExist
work correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the Functionality of it doesn't have any affect(if it has any may be I would have caught in the unit tests), it is the name that looks a bit redundant may be not following the naming conventions in java properly, I followed because to maintain similarity with the other intializations
Title: Implement idempotency for account creation in CreateHandler
Description:
This PR implements idempotency for account creation in the CreateHandler of the AWS Organizations Account resource. The changes ensure that attempting to create an account that already exists results in an appropriate error response rather than attempting to create a duplicate account.
Key Changes:
Specific Updates:
In CreateHandler:
In CreateHandlerTest:
In CallbackContext:
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.