-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Github action to create release PR #164
Conversation
UI components are released independently - it seems like this will release both at once with one version? Unless I'm missing something. |
Yes, it will release both components at the same time. I'll update it so the components are released independently. |
@mattcreaser I've updated the action so that each component can be released separately as a GH workflow dispatch input. |
How is the changelog created. Ex: if we are releasing liveness is it going to inclue authenticator commits in changelog. This could be problematic when we then go to release authenticator and those changes are not included in changelog. This effort is the reason we hadn't automated it yet. If this part has been resolved (including changes only for plugin between now and previous release + any core dependency updates during that time), this would be extremely helpful. |
…ommit message scopes
@tylerjroach Good callout, I've updated the configuration and changelog generation so that it accounts for commit message scopes. The changelog generation for Liveness will exclude all commits that is scoped for Authenticator and vice-versa. All commits without a scope or isn't marked as ignored/exclude will be included by default. |
@phantumcode You may have already covered this, but as an example. Lets say we update the material 3 library.
Will both the next release of liveness and authenticator include this change? Or will only the first of these released include it? Sorry for asking so many questions, its difficult to fully understand what is being generated without seeing examples. |
@tylerjroach By default, both releases will include commits that are not part of the ignore/exclude list. So in your example, both releases will include the |
We could formalize this by requiring all commits to have scope of either |
Issue #, if available:
Description of changes:
How did you test these changes?
Adding Github action to automate the initial release PR with update versions for Liveness and Authenticator.
Depends on changes from this PR: aws-amplify/amplify-ci-support#179
Release action will update the following files:
Documentation update required?
General Checklist
Added Unit TestsAdded Integration TestsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.