Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove .idea directories from the sample apps #153

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

vincetran
Copy link
Member

Issue #, if available: N/A

Description of changes: Noticed during development that my Android Studio instance was modifying .idea files in the sample apps. From the .gitignore, it looks like we want to ignore them but the regex was only checking .idea in the top-level dir. Updated that regex and removed the existing .idea folders from the Auth and Liveness sample apps.

How did you test these changes?
After making the change in the .gitignorefile, made a .idea folder in a different folder and creating some files to make sure none of them were picked up by git.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners May 31, 2024 20:05
@mattcreaser mattcreaser enabled auto-merge July 15, 2024 17:07
auto-merge was automatically disabled September 11, 2024 20:06

Merge commits are not allowed on this repository

@vincetran vincetran merged commit 9b42ebd into main Sep 11, 2024
1 check passed
@vincetran vincetran deleted the chore-remove-idea-dir branch September 11, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants