Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: Authenticator 1.1.0 #120

Merged
merged 3 commits into from
Feb 15, 2024
Merged

release: Authenticator 1.1.0 #120

merged 3 commits into from
Feb 15, 2024

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Feb 13, 2024 •
edited
Loading

How did you test these changes?
tested authenticator locally!

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tjleing tjleing marked this pull request as ready for review February 14, 2024 20:53
@tjleing tjleing requested review from a team as code owners February 14, 2024 20:53
mattcreaser
mattcreaser requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@mattcreaser mattcreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update authenticator sample to reference new release.

authenticator/CHANGELOG.md Show resolved Hide resolved
@tjleing tjleing requested a review from mattcreaser February 15, 2024 17:04
@tjleing tjleing added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit fbd75b4 Feb 15, 2024
1 check passed
@tjleing tjleing deleted the release-authenticator-1.1.0 branch February 15, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcreaser mattcreaser mattcreaser approved these changes

@ankpshah ankpshah ankpshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjleing @mattcreaser @ankpshah