Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore VisibleForTesting-annotated elements for purposes of api validation #117

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Feb 8, 2024

Issue #, if available:

Description of changes:

  • Elements marked @VisibleForTesting are not part of the public API

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners February 8, 2024 18:14
@mattcreaser mattcreaser force-pushed the mattcreaser/ignore-visble-for-testing branch from 564ec2e to bc43dcf Compare February 8, 2024 18:14
@mattcreaser mattcreaser enabled auto-merge February 8, 2024 19:03
@mattcreaser mattcreaser added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit a8d2d96 Feb 12, 2024
1 check passed
@mattcreaser mattcreaser deleted the mattcreaser/ignore-visble-for-testing branch February 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants