Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(liveness): Update Liveness UI #100

Merged
merged 20 commits into from
Nov 30, 2023
Merged

feat(liveness): Update Liveness UI #100

merged 20 commits into from
Nov 30, 2023

Conversation

tylerjroach
Copy link
Member

@tylerjroach tylerjroach commented Nov 29, 2023

Issue #, if available:

Description of changes:

  • Update the start screen to latest designs from Liveness team
  • Fix: If the liveness view is removed (ex: back pressed), and a new session is started, the previous websocket would cause the camera to close if the server closed the socket while the second session was in progress.
  • Fix: The liveness match timeout timer was not getting canceled if the detector was stopped. This could have caused the camera to close on a new session once the timer completed.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested review from a team as code owners November 29, 2023 17:43
Copy link
Contributor

@tjleing tjleing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nit! Will note that I'm able to block the freshness check from proceeding by moving my face away from the camera during the 1000ms wait time we introduced. Haven't done a super deep dive but I think onFrameFaceUpdate isn't actually being called if there's no visible face, which makes sense to me.

tjleing
tjleing previously approved these changes Nov 30, 2023
ankpshah
ankpshah previously approved these changes Nov 30, 2023
@tylerjroach tylerjroach added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@tjleing tjleing dismissed stale reviews from ankpshah and themself via 6d79e5b November 30, 2023 19:20
ankpshah
ankpshah previously approved these changes Nov 30, 2023
@tjleing tjleing added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit d87e9d9 Nov 30, 2023
@tjleing tjleing deleted the tjroach/ui-updates branch November 30, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants