Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load region from AWS client if the credentials are managed by AWS-SDK #14097

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Amplifiyer
Copy link
Contributor

@Amplifiyer Amplifiyer commented Feb 5, 2025

Description of changes

When using general configLevel for aws credentials, deployment manager was failing because it expected amplify-cli to resolve credentials (and hence region) whereas general config implies that credentials are managed by customers and resolved by aws-sdk automatically without cli doing anything. This change removes the validation and instead defaults to AWS client's region instead of taking it away completely to reduce the scope of this change.

Reference: https://docs.amplify.aws/gen1/react/tools/cli/usage/headless/#--providers-1

See this for a similar example.

Issue #, if available

Description of how you validated changes

Manually tested before and after and confirmed that it fixes the issue.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Amplifiyer Amplifiyer requested a review from a team as a code owner February 5, 2025 17:45
@Amplifiyer Amplifiyer merged commit 9d1bb1a into dev Feb 5, 2025
6 checks passed
@Amplifiyer Amplifiyer deleted the V1664968988 branch February 5, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants