fix: load region from AWS client if the credentials are managed by AWS-SDK #14097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When using
general
configLevel for aws credentials, deployment manager was failing because it expected amplify-cli to resolve credentials (and hence region) whereasgeneral
config implies that credentials are managed by customers and resolved by aws-sdk automatically without cli doing anything. This change removes the validation and instead defaults to AWS client'sregion
instead of taking it away completely to reduce the scope of this change.Reference: https://docs.amplify.aws/gen1/react/tools/cli/usage/headless/#--providers-1
See this for a similar example.
Issue #, if available
Description of how you validated changes
Manually tested before and after and confirmed that it fixes the issue.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.