Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): Create use cases for device management APIs #2979

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Moves logic for device management APIs (remember device, forget device, fetch devices) out of RealAWSAuthCognitoPlugin and into use case classes.

How did you test these changes?
Unit tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 20 lines in your changes missing coverage. Please review.

Project coverage is 41.92%. Comparing base (7f874ed) to head (11d40c9).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
- Coverage   44.01%   41.92%   -2.09%     
==========================================
  Files         926      974      +48     
  Lines       30485    31780    +1295     
  Branches     4351     4729     +378     
==========================================
- Hits        13419    13325      -94     
- Misses      15601    16942    +1341     
- Partials     1465     1513      +48     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant