Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional_plugins: spawner_remote: add setup_timeout option for remote host setup hook #6118

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

zoumingzhe
Copy link
Contributor

Fixes: #6117

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zoumingzhe, thank you very much for contributing to the Avocado, this fix is more than welcome. The changes LGTM. The only issue is that your commit is missing your signature described in our style guide. Could you please add Signed-off-by: Mingzhe Zou <[email protected]> as last line of you commit? Thank you.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.13%. Comparing base (a24b10c) to head (fa885ae).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../spawner_remote/avocado_spawner_remote/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6118      +/-   ##
==========================================
- Coverage   67.15%   67.13%   -0.03%     
==========================================
  Files         203      203              
  Lines       21977    21980       +3     
==========================================
- Hits        14759    14756       -3     
- Misses       7218     7224       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoumingzhe
Copy link
Contributor Author

Hi @zoumingzhe, thank you very much for contributing to the Avocado, this fix is more than welcome. The changes LGTM. The only issue is that your commit is missing your signature described in our style guide. Could you please add Signed-off-by: Mingzhe Zou <[email protected]> as last line of you commit? Thank you.

ok, signed

@richtja richtja merged commit 3bcf0f7 into avocado-framework:master Feb 10, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 110
Development

Successfully merging this pull request may close these issues.

optional_plugins: spawner_remote: run_remote_cmd_async() missing 1 required positional argument: 'timeout'
2 participants