Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to rectify the attribute decode issue. #5851

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

FarooqAbdulla02
Copy link
Contributor

@FarooqAbdulla02 FarooqAbdulla02 commented Jan 10, 2024

This patch includes the fix for "ERROR: 'CmdResult' object has no attribute 'decode'".

Run logs

without patch

ltcden4-lp12:~/avocado-fvt-wrapper/tests/avocado-misc-tests/io/net # avocado run irqbalance.py -m irqbalance.py.data/irqbalance_network.yaml --max-parallel-tasks=1
JOB ID : 289cf143a056fa246812f6e8ed20db603beedd65
JOB LOG : /root/avocado-fvt-wrapper/results/job-2023-12-30T06.19-289cf14/job.log
(1/4) irqbalance.py:irq_balance.test_irq_balance;run-41ce: STARTED
(1/4) irqbalance.py:irq_balance.test_irq_balance;run-41ce: ERROR: 'CmdResult' object has no attribute 'decode' (4.32 s)
(2/4) irqbalance.py:irq_balance.test_cpu_serial_off_on;run-41ce: STARTED
(2/4) irqbalance.py:irq_balance.test_cpu_serial_off_on;run-41ce: ERROR: 'CmdResult' object has no attribute 'decode' (4.17 s)
(3/4) irqbalance.py:irq_balance.test_smt_toggle;run-41ce: STARTED
(3/4) irqbalance.py:irq_balance.test_smt_toggle;run-41ce: ERROR: 'CmdResult' object has no attribute 'decode' (4.22 s)
(4/4) irqbalance.py:irq_balance.test_taskset;run-41ce: STARTED
(4/4) irqbalance.py:irq_balance.test_taskset;run-41ce: ERROR: 'CmdResult' object has no attribute 'decode' (4.22 s)
RESULTS : PASS 0 | ERROR 4 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2023-12-30T06.19-289cf14/results.html
JOB TIME : 51.34 s

with latest patch

ltcden4-lp12:~/avocado-fvt-wrapper/tests/avocado-misc-tests/io/net # avocado run irqbalance.py -m irqbalance.py.data/irqbalance_network.yaml --max-parallel-tasks=1
JOB ID : cb3805fb124b50c0dc823c2f12b580b0977f6fa6
JOB LOG : /root/avocado-fvt-wrapper/results/job-2023-12-30T06.22-cb3805f/job.log
(1/4) irqbalance.py:irq_balance.test_irq_balance;run-41ce: STARTED
(1/4) irqbalance.py:irq_balance.test_irq_balance;run-41ce: PASS (910.94 s)
(2/4) irqbalance.py:irq_balance.test_cpu_serial_off_on;run-41ce: STARTED
(2/4) irqbalance.py:irq_balance.test_cpu_serial_off_on;run-41ce: PASS (8.20 s)
(3/4) irqbalance.py:irq_balance.test_smt_toggle;run-41ce: STARTED
(3/4) irqbalance.py:irq_balance.test_smt_toggle;run-41ce: PASS (9.05 s)
(4/4) irqbalance.py:irq_balance.test_taskset;run-41ce: STARTED
(4/4) irqbalance.py:irq_balance.test_taskset;run-41ce: PASS (5.00 s)
RESULTS : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2023-12-30T06.22-cb3805f/results.html
JOB TIME : 975.05 s

@FarooqAbdulla02
Copy link
Contributor Author

Run logs
irqbalance.log

Copy link
Contributor

@abdhaleegit abdhaleegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This patch includes the fix for "ERROR: 'CmdResult' object has no
attribute 'decode'".

Signed-off-by: Shaik Abdulla <[email protected]>
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @FarooqAbdulla02

@richtja richtja merged commit f499e72 into avocado-framework:master Jan 10, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants