Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw image format by default for block devices #4042

Merged
merged 1 commit into from
Jan 17, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions virttest/qemu_devices/qcontainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -2563,9 +2563,11 @@ def define_hbas(
format_cls = qdevices.QBlockdevFormatLuks
elif imgfmt == "nvme":
format_cls = qdevices.QBlockdevFormatRaw
elif imgfmt is None:
# use RAW type as the default
elif imgfmt is None or imgfmt == "":
# use RAW type as the default (None or empty string)
format_cls = qdevices.QBlockdevFormatRaw
else:
raise ValueError(f"Unsupported image format: {imgfmt}")

protocol_node = protocol_cls(name)
devices.append(protocol_node)
Expand Down