network_xml:Update to support setting up hostname xmls with a list of hostname strings #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanli1
approved these changes
Nov 1, 2024
yalzhang
approved these changes
Nov 11, 2024
cliping
approved these changes
Nov 11, 2024
smitterl
suggested changes
Dec 4, 2024
hostname strings Then we can directly use the values getting from a netxml.hostnames to set the value of netxml.hostnames without having to convert it from a list of dicts to a list of strings. Signed-off-by: Haijiao Zhao <[email protected]>
|
@smitterl Test result can be found here: autotest/tp-libvirt#5950 |
Yingshun
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then we can directly use the values getting from a netxml.hostnames to set
the value of netxml.hostnames without having to convert it from a list
of dicts to a list of strings.
Test result can be found here: autotest/tp-libvirt#5950
Tested with a case affected by this code change (from #3629)