libvirt_numa: Fix parsing of continuous numa nodes #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR#3804, a similar bug is fixed by replacing parse_numa_nodeset_to_str with the new convert_all_nodes_to_string function. However, parse_numa_nodeset_to_str is still called at several places. Therefore, in this PR, directly call convert_all_nodes_to_string in parse_numa_nodeset_to_str to fix the bug with minimal changes. Signed-off-by: Qian Jianhua <[email protected]>
|
@dzhengfy Could you please review this PR for me? |
dzhengfy
reviewed
May 15, 2024
| ) | ||
|
|
||
| LOG.debug("Parse output for numa nodeset: '%s'", numa_nodeset) | ||
| numa_nodeset = convert_all_nodes_to_string(node_list) |
There was a problem hiding this comment.
If convert_all_nodes_to_string() could completely replace the old function, we'd better replace it completely, which is to replace in tp-libvirt instead of keeping old function as a shell. Thanks
There was a problem hiding this comment.
Thank you. I have removed parse_numa_nodeset_to_str(). And add a PR for tp-libvirt autotest/tp-libvirt#5616. Please review it again.
added 3 commits
May 15, 2024 16:17
Signed-off-by: Qian Jianhua <[email protected]>
Signed-off-by: Qian Jianhua <[email protected]>
Signed-off-by: Qian Jianhua <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR#3804, a similar bug is fixed by replacing parse_numa_nodeset_to_str with the new convert_all_nodes_to_string function. However, parse_numa_nodeset_to_str is still called at several places. Therefore, in this PR, directly call convert_all_nodes_to_string in parse_numa_nodeset_to_str to fix the bug with minimal changes.
Signed-off-by: Qian Jianhua [email protected]
Before:
After: