Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the get_default_gateway #3816

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix the get_default_gateway #3816

merged 1 commit into from
Dec 21, 2023

Conversation

yalzhang
Copy link
Contributor

Without the session parameter, utils_misc.cmd_status_output() will always get default gateway from the host. Fix the issue by adding the parameter.

@yalzhang
Fix the get_default_gateway
0f391e9 
Without the session parameter, utils_misc.cmd_status_output() will
always get default gateway from the host. Fix the issue by adding
the parameter.

Signed-off-by: Yalan Zhang <[email protected]>
@yalzhang
Copy link
Contributor Author

yalzhang commented Dec 19, 2023 •
edited
Loading

before the fix, the cases fail

 (1/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.default: STARTED
 (1/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.default: FAIL: The gateway on guest is 10.73.11.254, while expect is 10.0.2.2 (84.66 s)
 (2/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.ignore_prefix: STARTED
 (2/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.ignore_prefix: FAIL: The gateway on guest is 10.73.11.254, while expect is 100.0.2.2 (138.48 s)
 (3/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.set_prefix: STARTED
 (3/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.set_prefix: FAIL: The gateway on guest is 10.73.11.254, while expect is 100.100.100.2 (134.95 s)
 (4/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.root_user: STARTED
 (4/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.root_user: FAIL: default ipv4 gateway not match. Expect 10.0.2.2, but got 10.73.11.254 (52.01 s)
 (5/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.non_root_user: STARTED
 (5/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.non_root_user: FAIL: default ipv4 gateway not match. Expect 10.0.2.2, but got 10.73.11.254 (55.56 s)
 (6/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.root_user: STARTED
 (6/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.root_user: FAIL: default ipv4 gateway not match. Expect \d+.0.2.2, but got 10.73.11.254 (58.12 s)
 (7/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.non_root_user: STARTED
 (7/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.non_root_user: FAIL: default ipv4 gateway not match. Expect \d+.0.2.2, but got 10.73.11.254 (55.58 s)
 (8/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.root_user: STARTED
 (8/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.root_user: FAIL: default ipv4 gateway not match. Expect 100.100.100.2, but got 10.73.11.254 (57.80 s)
 (9/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.non_root_user: STARTED
 (9/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.non_root_user: FAIL: default ipv4 gateway not match. Expect 100.100.100.2, but got 10.73.11.254 (54.63 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 9 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2023-12-19T00.39-76fa6b2/results.html
JOB TIME   : 698.23 s

After the fix, the cases pass

 (1/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.default: STARTED
 (1/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.default: PASS (86.04 s)
 (2/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.ignore_prefix: STARTED
 (2/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.ignore_prefix: PASS (134.83 s)
 (3/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.set_prefix: STARTED
 (3/9) type_specific.io-github-autotest-libvirt.virtual_network.iface_options.iface_type.type_user.type_user_set_ip.set_prefix: PASS (135.43 s)
 (4/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.root_user: STARTED
 (4/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.root_user: PASS (147.13 s)
 (5/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.non_root_user: STARTED
 (5/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.default.non_root_user: PASS (64.38 s)
 (6/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.root_user: STARTED
 (6/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.root_user: PASS (144.69 s)
 (7/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.non_root_user: STARTED
 (7/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.no_prefix.non_root_user: PASS (64.18 s)
 (8/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.root_user: STARTED
 (8/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.root_user: PASS (145.24 s)
 (9/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.non_root_user: STARTED
 (9/9) type_specific.io-github-autotest-libvirt.virtual_network.connectivity_check.user_interface.positive_test.customized_ip.with_prefix.non_root_user: PASS (64.60 s)
RESULTS    : PASS 9 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2023-12-19T00.19-a3e1781/results.html
JOB TIME   : 992.98 s

@yalzhang
Copy link
Contributor Author

@Yingshun Please help to review, Thank you!

dzhengfy
dzhengfy approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy dzhengfy merged commit d965af3 into avocado-framework:master Dec 21, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhengfy dzhengfy dzhengfy approved these changes

@Yingshun Yingshun Yingshun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yalzhang @dzhengfy @Yingshun