utils_libvirt/libvirt_disk: add function to get disk by serial #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
get_disk_by_serial
branch
2 times, most recently
from
a9bf763 to
ae230b5
Compare
|
@chunfuwen Please help review. As mentioned on #3811 (comment) unfortunately we can't set serial on LUNs but its implementation might be useful on other occasions. |
Use the SERIAL that can be set via libvirt, to select its disk path under /dev/. Suggested-by: Chunfu Wen <[email protected]> Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
get_disk_by_serial
branch
from
ae230b5 to
51863db
Compare
|
@smitterl ,could you upload one simple test result? |
dzhengfy
reviewed
Jan 28, 2024
| @@ -102,6 +102,31 @@ def get_non_root_disk_name(session): | |||
| return name.strip(), mpoint.strip() | |||
|
|
|||
|
|
|||
| def get_disk_by_serial(session, serial): | |||
There was a problem hiding this comment.
We already have same function in utils_disk.py.
def get_disk_by_serial(serial_str, session=None):
There was a problem hiding this comment.
Thanks for the pointer. I'll close this one.
|
Closing this as there is already another implementation with the same API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the SERIAL to identify a disk and return its path.
Suggested-by: Chunfu Wen [email protected]
Signed-off-by: Sebastian Mitterle [email protected]