Support to specify virtio-win's version range #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leidwang
force-pushed
the
check_virtio_driver_version
branch
from
1808fd7 to
3acccf7
Compare
|
Hi @vivianQizhu I add a checkpoint to support specify a range for virtio-win's version. |
vivianQizhu
reviewed
Dec 5, 2023
leidwang
force-pushed
the
check_virtio_driver_version
branch
from
3acccf7 to
0712138
Compare
|
@xiagao Would you please help review? Thanks. |
vivianQizhu
reviewed
Dec 5, 2023
leidwang
force-pushed
the
check_virtio_driver_version
branch
from
0712138 to
269c73d
Compare
vivianQizhu
reviewed
Dec 19, 2023
leidwang
force-pushed
the
check_virtio_driver_version
branch
3 times, most recently
from
e86ba93 to
9ceb8b2
Compare
vivianQizhu
reviewed
Dec 27, 2023
vivianQizhu
reviewed
Dec 27, 2023
leidwang
force-pushed
the
check_virtio_driver_version
branch
from
9ceb8b2 to
86d1eb3
Compare
vivianQizhu
reviewed
Dec 27, 2023
leidwang
force-pushed
the
check_virtio_driver_version
branch
2 times, most recently
from
fedb1bf to
c2e0c2f
Compare
|
@yanan-fu Would you please help review this one? Many thanks. |
|
Sorry for missing needinfo. |
leidwang
force-pushed
the
check_virtio_driver_version
branch
9 times, most recently
from
73667e8 to
fedb1bf
Compare
leidwang
force-pushed
the
check_virtio_driver_version
branch
2 times, most recently
from
cddc1ca to
0b2da7f
Compare
Okay, removed the redundant commit, thanks @yanan-fu @vivianQizhu |
yanan-fu
reviewed
Jan 19, 2024
leidwang
force-pushed
the
check_virtio_driver_version
branch
5 times, most recently
from
53aa939 to
2e0b377
Compare
|
Hi @yanan-fu I updated the PR as we discussed offline, would you please review it again? Thanks! |
yanan-fu
reviewed
Jan 22, 2024
Add a checkpoint here to check the virtio-win version, if the version is in the specified range, test will continue, if not, cancel the test. Signed-off-by: Leidong Wang <[email protected]>
leidwang
force-pushed
the
check_virtio_driver_version
branch
from
2e0b377 to
a6681c4
Compare
vivianQizhu
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a checkpoint here to check the virtio-win version, if the version is in the specified range, test will continue, if not, cancel the test.
ID:1594