Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machines: update default indirect_image_blacklist for s390x #3796

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

fbq815
Copy link
Contributor

@fbq815 fbq815 commented Nov 16, 2023

General: update default indirect_image_blacklist for s390x, we could use
FCP SCSI as the system disk start from z15 as well.

ID: 1540

Signed-off-by: Boqiao Fu [email protected]

@fbq815
Copy link
Contributor Author

fbq815 commented Nov 16, 2023

@YongxueHong @PaulYuuu please help me review this patch, thx

@PaulYuuu
Copy link
Contributor

Hello @fbq815, can you explain more? I see 9dadd01 mentioned s390x usually uses /dev/dasd* devices to boot from, but not you change to common value sd*, all composes match this? Or only the newest? How about (?:da)?sda[\d]*.

>>> re.findall('(?:da)?sda[\d]*', 'sda1')
['sda1']
>>> re.findall('(?:da)?sda[\d]*', 'dasda1')
['dasda1']

@fbq815
Copy link
Contributor Author

fbq815 commented Nov 16, 2023

Hello @fbq815, can you explain more? I see 9dadd01 mentioned s390x usually uses /dev/dasd* devices to boot from, but not you change to common value sd*, all composes match this? Or only the newest? How about (?:da)?sda[\d]*.

>>> re.findall('(?:da)?sda[\d]*', 'sda1')
['sda1']
>>> re.findall('(?:da)?sda[\d]*', 'dasda1')
['dasda1']

double check with developers that before z13 we only have dasd as the system disk, updated thanks for highlight!

Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YongxueHong
Copy link
Contributor

Hi @fbq815
Please add the namespace prefix machines: for the commit header.
like:
machines: update default indirect_image_blacklist for s390x
Thanks.

General: update default indirect_image_blacklist for s390x, we could use
FCP SCSI as the system disk start from z15 as well.

Signed-off-by: Boqiao Fu <[email protected]>
@fbq815
Copy link
Contributor Author

fbq815 commented Nov 21, 2023

Updated, please help me merge this patch @PaulYuuu @YongxueHong

@fbq815 fbq815 changed the title update default indirect_image_blacklist for s390x Machines: update default indirect_image_blacklist for s390x Nov 21, 2023
@YongxueHong YongxueHong merged commit ad60451 into avocado-framework:master Nov 21, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants