-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machines: update default indirect_image_blacklist for s390x #3796
Conversation
@YongxueHong @PaulYuuu please help me review this patch, thx |
Hello @fbq815, can you explain more? I see 9dadd01 mentioned >>> re.findall('(?:da)?sda[\d]*', 'sda1')
['sda1']
>>> re.findall('(?:da)?sda[\d]*', 'dasda1')
['dasda1'] |
double check with developers that before z13 we only have dasd as the system disk, updated thanks for highlight! |
92aba09
to
5798873
Compare
5798873
to
ba46d7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @fbq815 |
General: update default indirect_image_blacklist for s390x, we could use FCP SCSI as the system disk start from z15 as well. Signed-off-by: Boqiao Fu <[email protected]>
ba46d7e
to
3029466
Compare
Updated, please help me merge this patch @PaulYuuu @YongxueHong |
General: update default indirect_image_blacklist for s390x, we could use
FCP SCSI as the system disk start from z15 as well.
ID: 1540
Signed-off-by: Boqiao Fu [email protected]