check-lint: add support for subdirectories from config file #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtja
reviewed
Sep 11, 2024
| @@ -66,15 +66,19 @@ if [ -f "$CONFIG_FILE" ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # Get all Python files in the specified directory | |||
| FILES=$(git ls-files "$DIRECTORY_PATH/*.py") | |||
There was a problem hiding this comment.
Hi @clebergnu, this solution works, but I would prefer a simpler solution git ls-files $DIRECTORY_PATH/ | grep .py what do you think?
There was a problem hiding this comment.
Hi @clebergnu, this solution works, but I would prefer a simpler solution
git ls-files $DIRECTORY_PATH/ | grep .pywhat do you think?
Works for me as well.
Currently, when using the "avocado-static-checks.conf" configuration file to specify the pylint configuration for a specific directory, only the files on the immediate directory are used. This is a problem with complex projects, such as Avocado itself, that have many subdirectories. With this change, all the Python files in subdirectories starting from the directory given in the "avocado-static-checks.conf" file will be used. The side effect of this change is that, if one intends to use different configurations for different subdirectories, then the base directory must not be given, but all subdirectories starting from where the configuration diverges must be entered in the "avocado-static-checks.conf" file. Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
lint_subdirs
branch
from
f4fb548 to
09cdaf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using the "avocado-static-checks.conf" configuration file to specify the pylint configuration for a specific directory, only the files on the immediate directory are used.
This is a problem with complex projects, such as Avocado itself, that have many subdirectories.
With this change, all the Python files in subdirectories starting from the directory given in the "avocado-static-checks.conf" file will be used. The side effect of this change is that, if one intends to use different configurations for different subdirectories, then the base directory must not be given, but all subdirectories starting from where the configuration diverges must be entered in the "avocado-static-checks.conf" file.
Reference: avocado-framework/avocado#5989