Add lint check based on pylint #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a lint check based on pylint. It is the first check with
relies on a configuration file rather than command line options.
This configuration file is heavily based on Avocado's configuration,
but it's different in a few aspects:
1) It's more strict, as in less pylint checks are disabled (55 checks
are disabled in Avocado, while only 10 are disabled here)
2) The name of the checks are used, instead of the less descriptive
"category + number" identification.
Signed-off-by: Cleber Rosa <[email protected]>
richtja
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Hi @clebergnu the code LGTM and we can merge it. But I just have one topic for discussion here. Please tell me what do you think about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lint check based on pylint. It is the first check with relies on a configuration file rather than command line options.
This configuration file is heavily based on Avocado's configuration, but it's different in a few aspects:
It's more strict, as in less pylint checks are disabled (55 checks
are disabled in Avocado, while only 10 are disabled here)
The name of the checks are used, instead of the less descriptive
"category + number" identification.