Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint check to use bash interpreter #12

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Oct 3, 2024

The check-lint script uses some bash features, therefore it needs to be specified with shebang. Because on some platforms this script may not work properly. For example, Ubuntu and dash interpreter which is used by some of our CIs.

The check-lint script uses some bash features, therefore it needs to be
specified with shebang. Because on some platforms this script may not
work properly. For example, Ubuntu and `dash` interpreter which is used
by some of our CIs.

Signed-off-by: Jan Richter <[email protected]>
@richtja richtja added the bug Something isn't working label Oct 3, 2024
@richtja richtja self-assigned this Oct 3, 2024
@richtja
Copy link
Contributor Author

richtja commented Oct 3, 2024

This is a fix for avocado pre-release tests. See https://github.com/avocado-framework/avocado/actions/runs/11161562233/job/31024373090

@harvey0100
Copy link
Contributor

Thanks for the change :)

@richtja richtja merged commit aac9062 into avocado-framework:main Oct 4, 2024
1 check passed
@richtja richtja deleted the lint_check_bash branch October 4, 2024 07:53
richtja added a commit to richtja/avocado that referenced this pull request Oct 4, 2024
This update is needed to use the latest changes in avocado-static-checks
submodule, which are fixing issues in avocado's pre-release checks.

Reference:
avocado-framework/avocado-static-checks#12
Signed-off-by: Jan Richter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants