Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Stability #25

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

harvey0100
Copy link
Contributor

Autils code is fetched from the pull request using the github.event.pull_request.head.sha. The tests are fetched from the master branch by running git fetch origin master and checking out only the tests/ directory from the master branch.

Reference: #23

Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harvey0100, this looks good to me. I just wonder if there's any way to avoid re-running the tests, if there are no changes in the tests. This question is about an optimization, so no worries if it's not possible or too expensive to implement.

Autils code is fetched from the pull request using the github.event.pull_request.head.sha.
The tests are fetched from the master branch by running git fetch origin master
and checking out only the tests/ directory from the master branch.

Reference:      avocado-framework#23
Signed-off-by: Harvey Lynden <[email protected]>
@harvey0100
Copy link
Contributor Author

harvey0100 commented Nov 1, 2024

Hi @harvey0100, this looks good to me. I just wonder if there's any way to avoid re-running the tests, if there are no changes in the tests. This question is about an optimization, so no worries if it's not possible or too expensive to implement.

Hi @clebergnu ,

I've introduced using Git Actions steps this will check the difference to the main branch if there are any changes to the tests directory and will only run installation / tests in the scenario that something changed.

Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clebergnu clebergnu merged commit 2d408e0 into avocado-framework:main Nov 4, 2024
4 checks passed
@richtja richtja mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

3 participants