memory usage metrics #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugrimov
reviewed
Feb 16, 2024
aqueduct/metrics/collect.py
Outdated
| @@ -29,12 +29,16 @@ def __init__(self): | |||
| super().__init__() | |||
| self.queue_sizes = MetricsItems() | |||
| self.tasks_stats = TasksStats() | |||
| self.flow_steps_memory_usage = MetricsItems() | |||
There was a problem hiding this comment.
there is no another memory usage metrics planned, so t will be good if you rename flow_steps_memory_usage into memory_usage everywhere in this PR
bugrimov
reviewed
Feb 16, 2024
aqueduct/flow.py
Outdated
| @@ -302,6 +315,7 @@ def _run_tasks(self): | |||
| self._tasks.append(asyncio.ensure_future(self._check_is_alive())) | |||
|
|
|||
| self._metrics_manager.start(queues_info=self._get_queues_info()) | |||
| self._metrics_manager.collector.add_flow_steps_memory_usage(self._get_flow_steps_memory_usage()) | |||
There was a problem hiding this comment.
It seems run only once at start. For regular run you need add while True inside _get_flow_steps_memory_usage with some sleep time
There was a problem hiding this comment.
Is it correct to replace while True with while self.state != FlowState.STOPPED?
bugrimov
requested changes
Feb 16, 2024
cyberlis
reviewed
Feb 16, 2024
aqueduct/flow.py
Outdated
| @@ -5,6 +5,7 @@ | |||
| import queue | |||
| import signal | |||
| import sys | |||
| import psutil | |||
There was a problem hiding this comment.
It is not a standard module
You need to add it to setup.py to required
And to requirements/dev.txt
bugrimov
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.