[ADD] hr_timesheet_stop_button: In Timesheets new fields: Start Date,… #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avanzosc/developers .... review please |
anajuaristi
approved these changes
Dec 21, 2021
oihane
reviewed
Dec 21, 2021
Comment on lines
11
to
10
| start_date = fields.Datetime( | ||
| string='Start date', default=fields.datetime.now()) |
There was a problem hiding this comment.
Modificar este campo debería de modificar el campo de fecha de imputacion.
There was a problem hiding this comment.
Realizado lo solicitado por @oihane , eskerrik asko.
oihane
previously requested changes
Dec 21, 2021
Comment on lines
13
to
12
| end_date = fields.Datetime( | ||
| string='End date') |
There was a problem hiding this comment.
Modificar este campo, debería de hacer el recálculo del importe.
There was a problem hiding this comment.
Tenido en cuenta lo solicitado por @oihane , eskerrik asko.
alfredoavanzosc
force-pushed
the
hr-addons12-hr_timesheet_stop_button
branch
from
1773384 to
c75f6ac
Compare
alfredoavanzosc
dismissed
oihane’s stale review
Realizado lo solicitado. Eskerrik asko.
alfredoavanzosc
force-pushed
the
hr-addons12-hr_timesheet_stop_button
branch
2 times, most recently
from
8b38147 to
b931fe9
Compare
alfredoavanzosc
force-pushed
the
hr-addons12-hr_timesheet_stop_button
branch
from
b931fe9 to
65b5e69
Compare
anajuaristi
reviewed
Jan 24, 2022
| class AccountAnalyticLine(models.Model): | ||
| _inherit = 'account.analytic.line' | ||
|
|
||
| start_date = fields.Datetime( |
There was a problem hiding this comment.
Haremos compatible este módulo con hr_timesheet_usability de OCA
- Eliminar los campos start date y end date
- Al crear la línea meter en el campo "hora inicio" del módulo de OCa, la de la creación de la línea
| string='End date') | ||
|
|
||
| @api.onchange('start_date', 'end_date') | ||
| def _onchange_start_end_date(self): |
There was a problem hiding this comment.
No hace falta porque ya el de OCA hace el onchange
| self.unit_amount = self._compute_new_duration( | ||
| self.end_date, self.start_date) | ||
|
|
||
| def action_end_button(self): |
… and End Date. Also new button "Put end date".
alfredoavanzosc
force-pushed
the
hr-addons12-hr_timesheet_stop_button
branch
from
65b5e69 to
6e11f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and End Date. Also new button "Put end date".