Create caption files during transcoding #6145
Conversation
masaball
force-pushed
the
caption_extraction
branch
2 times, most recently
from
7e20070 to
56f3507
Compare
masaball
force-pushed
the
caption_extraction
branch
from
2a48529 to
b83f574
Compare
masaball
force-pushed
the
caption_extraction
branch
from
52cc612 to
048a650
Compare
| it 'uploads to Minio' do | ||
| encode.create! | ||
| expect(master_file).to have_received(:update_progress_on_success!) | ||
| end |
There was a problem hiding this comment.
Is there a check you can add here to ensure the file actually got uploaded? Maybe something along the lines of inspecting the supplemental file to make sure it is present, in minio, and non-zero length?
There was a problem hiding this comment.
I'm not sure. The Active Storage service is set at application boot and so the test suite is set to DiskService and I have been struggling to find a way to override that or mock it to test the Supplemental File.
Maybe we just remove this test and trust that Active Storage will properly do its thing?
There was a problem hiding this comment.
I think it would be good to keep this test as a check that the supplemental file gets attached in the after_completed callback. So maybe ActiveStorage service independent would be best. Do you think this tests enough?
supplemental_file = master_file.supplemental_files.last
expect(supplemental_file.file.present?).to eq true
expect(supplemental_file.file.byte_size > 0).to eq true
There was a problem hiding this comment.
That set of tests is probably sufficient, though Active Storage has an attached? method which may be better/more appropriate to check than present?. Will make the changes on Monday and see how it goes.
Related issue: #5702