Remove the Keystore API (#3657)

.github/workflows/buf-push.yml

@@ -18,5 +18,7 @@ jobs:
       - uses: bufbuild/buf-action@v1
         with:
           input: "proto"
+          # Breaking changes are managed by the rpcchainvm protocol version.
+          breaking: false
           token: ${{ secrets.BUF_TOKEN }}
           version: 1.35.0

.github/workflows/ci.yml

@@ -133,6 +133,8 @@ jobs:
         with:
           input: "proto"
           pr_comment: false
+          # Breaking changes are managed by the rpcchainvm protocol version.
+          breaking: false
           # buf-action defaults to pushing on non-fork branch pushes
           # which is never desirable for this job. The buf-push job is
           # responsible for pushes.

RELEASES.md

@@ -6,10 +6,35 @@ This version is backwards compatible to [v1.12.0](https://github.com/ava-labs/av
 
 The plugin version is unchanged at `38` and is compatible with versions `v1.12.0-v1.12.1`.
 
+**This release removes the support for the long deprecated Keystore API. Any users still relying on the keystore API will not be able to update to this version, or any later versions, of Avalanchego until their dependency on the keystore API has been removed.**
+
 ### APIs
 
 - Deprecated:
   - `info.GetTxFee`
+  - `keystore.createUser`
+  - `keystore.deleteUser`
+  - `keystore.listUsers`
+  - `keystore.importUser`
+  - `keystore.exportUser`
+  - `avm.createAddress`
+  - `avm.createFixedCapAsset`
+  - `avm.createNFTAsset`
+  - `avm.createVariableCapAsset`
+  - `avm.export`
+  - `avm.exportKey`
+  - `avm.import`
+  - `avm.importKey`
+  - `avm.listAddresses`
+  - `avm.mint`
+  - `avm.mintNFT`
+  - `avm.send`
+  - `avm.sendMultiple`
+  - `avm.sendNFT`
+  - `wallet.send`
+  - `wallet.sendMultiple`
+  - `platform.exportKey`
+  - `platform.listAddresses`
 - Added:
   - `avm.GetTxFee`
   - `platform.getValidatorFeeConfig`
@@ -25,6 +50,7 @@ The plugin version is unchanged at `38` and is compatible with versions `v1.12.0
   - `--add-primary-network-delegator-fee`
   - `--add-subnet-validator-fee`
   - `--add-subnet-delegator-fee`
+- Removed `--api-keystore-enabled`
 
 ### What's Changed
 

api/common_args_responses.go

@@ -22,12 +22,6 @@ type JSONTxID struct {
 	TxID ids.ID `json:"txID"`
 }
 
-// UserPass contains a username and a password
-type UserPass struct {
-	Username string `json:"username"`
-	Password string `json:"password"`
-}
-
 // JSONAddress contains an address
 type JSONAddress struct {
 	Address string `json:"address"`
@@ -38,32 +32,6 @@ type JSONAddresses struct {
 	Addresses []string `json:"addresses"`
 }
 
-// JSONChangeAddr is the address change is sent to, if any
-type JSONChangeAddr struct {
-	ChangeAddr string `json:"changeAddr"`
-}
-
-// JSONTxIDChangeAddr is a tx ID and change address
-type JSONTxIDChangeAddr struct {
-	JSONTxID
-	JSONChangeAddr
-}
-
-// JSONFromAddrs is a list of addresses to send funds from
-type JSONFromAddrs struct {
-	From []string `json:"from"`
-}
-
-// JSONSpendHeader is 3 arguments to a method that spends (including those with tx fees)
-// 1) The username/password
-// 2) The addresses used in the method
-// 3) The address to send change to
-type JSONSpendHeader struct {
-	UserPass
-	JSONFromAddrs
-	JSONChangeAddr
-}
-
 // GetBlockArgs is the parameters supplied to the GetBlock API
 type GetBlockArgs struct {
 	BlockID  ids.ID              `json:"blockID"`