chore(lanelet2_map_validator): automate test code compilation and cat…

…egorize test codes (#183) * Categorize test codes Signed-off-by: TaikiYamada4 <[email protected]> * Rewrite CMakeLists.txt so that contributors doesn't have to write the test code name in it Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]>
autowarefoundation · Dec 26, 2024 · 2b00989 · 2b00989
1 parent 1ccfdf1
commit 2b00989
Show file tree

Hide file tree

Showing 12 changed files with 14 additions and 22 deletions.
diff --git a/map/autoware_lanelet2_map_validator/CMakeLists.txt b/map/autoware_lanelet2_map_validator/CMakeLists.txt
@@ -32,42 +32,34 @@ target_link_libraries(autoware_lanelet2_map_validator
 )
 
 if(BUILD_TESTING)
-  find_package(ament_index_cpp REQUIRED)
+  file(GLOB_RECURSE test_src "test/src/test_*.cpp")
+  ament_auto_add_library(autoware_lanelet2_map_validator_test_lib ${test_src})
 
-  # test for json processing
-  ament_add_ros_isolated_gtest(
-    json_processing_test
-    test/src/test_json_processing.cpp
-  )
+  target_include_directories(autoware_lanelet2_map_validator_test_lib PUBLIC
+    test/src/include
+    src/include)
 
-  target_link_libraries(
-    json_processing_test
+  target_link_libraries(autoware_lanelet2_map_validator_test_lib
     autoware_lanelet2_map_validator_lib
-    ament_index_cpp::ament_index_cpp
   )
 
   # test for general lanelet2 map validators
-  function(add_validation_test VALIDATION_NAME)
+  function(add_validation_test TEST_FILE)
+    get_filename_component(TEST_NAME ${TEST_FILE} NAME_WE)
+    string(REPLACE "test_" "" VALIDATION_NAME ${TEST_NAME})
     ament_add_ros_isolated_gtest(
       ${VALIDATION_NAME}_test
-      test/src/test_${VALIDATION_NAME}.cpp
+      ${TEST_FILE}
     )
     target_link_libraries(
       ${VALIDATION_NAME}_test
-      autoware_lanelet2_map_validator_lib
+      autoware_lanelet2_map_validator_test_lib
     )
   endfunction()
 
-  add_validation_test(missing_regulatory_elements_for_stop_lines)
-  add_validation_test(missing_regulatory_elements_for_crosswalks)
-  add_validation_test(missing_regulatory_elements_for_traffic_lights)
-  add_validation_test(regulatory_elements_details_for_crosswalks)
-  add_validation_test(regulatory_elements_details_for_traffic_lights)
-  add_validation_test(traffic_light_facing)
-  add_validation_test(missing_referrers_for_traffic_lights)
-  add_validation_test(intersection_area_validity)
-  add_validation_test(intersection_area_segment_type)
-  add_validation_test(intersection_area_dangling_reference)
+  foreach(TEST_FILE ${test_src})
+    add_validation_test(${TEST_FILE})
+  endforeach()
 endif()
 
 ament_auto_package(

diff --git a/...ng_regulatory_elements_for_crosswalks.cpp → ...ng_regulatory_elements_for_crosswalks.cpp b/...ng_regulatory_elements_for_crosswalks.cpp → ...ng_regulatory_elements_for_crosswalks.cpp
diff --git a/...atory_elements_details_for_crosswalks.cpp → ...atory_elements_details_for_crosswalks.cpp b/...atory_elements_details_for_crosswalks.cpp → ...atory_elements_details_for_crosswalks.cpp
diff --git a/...idator/test/src/map_validation_tester.hpp → ...est/src/include/map_validation_tester.hpp b/...idator/test/src/map_validation_tester.hpp → ...est/src/include/map_validation_tester.hpp
diff --git a/..._intersection_area_dangling_reference.cpp → ..._intersection_area_dangling_reference.cpp b/..._intersection_area_dangling_reference.cpp → ..._intersection_area_dangling_reference.cpp
diff --git a/...c/test_intersection_area_segment_type.cpp → ...n/test_intersection_area_segment_type.cpp b/...c/test_intersection_area_segment_type.cpp → ...n/test_intersection_area_segment_type.cpp
diff --git a/...t/src/test_intersection_area_validity.cpp → ...ction/test_intersection_area_validity.cpp b/...t/src/test_intersection_area_validity.cpp → ...ction/test_intersection_area_validity.cpp
diff --git a/...ng_regulatory_elements_for_stop_lines.cpp → ...ng_regulatory_elements_for_stop_lines.cpp b/...ng_regulatory_elements_for_stop_lines.cpp → ...ng_regulatory_elements_for_stop_lines.cpp
diff --git a/..._missing_referrers_for_traffic_lights.cpp → ..._missing_referrers_for_traffic_lights.cpp b/..._missing_referrers_for_traffic_lights.cpp → ..._missing_referrers_for_traffic_lights.cpp
diff --git a/...egulatory_elements_for_traffic_lights.cpp → ...egulatory_elements_for_traffic_lights.cpp b/...egulatory_elements_for_traffic_lights.cpp → ...egulatory_elements_for_traffic_lights.cpp
diff --git a/...y_elements_details_for_traffic_lights.cpp → ...y_elements_details_for_traffic_lights.cpp b/...y_elements_details_for_traffic_lights.cpp → ...y_elements_details_for_traffic_lights.cpp
diff --git a/...or/test/src/test_traffic_light_facing.cpp → ...affic_light/test_traffic_light_facing.cpp b/...or/test/src/test_traffic_light_facing.cpp → ...affic_light/test_traffic_light_facing.cpp