feat: apply `autoware_` prefix for `hazard_status_converter` #9971

sasakisasaki · 2025-01-19T11:28:31Z

Description

This pull request addresses the issue of inconsistent naming by adding the autoware_ prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.

How was this PR tested?

Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.

Directory Name
- Add autoware_ as a prefix to the directory name.
packages.xml
- Add autoware_ to the name element.
CMakeLists.txt
- Change the project name to autoware_***.
- Add autoware:: to PLUGIN.
Header Files (.hpp)
- Start #ifndef guards with AUTOWARE__.
- Add autoware:: to namespace.
Source Files (.cpp)
- Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
Launch Files
- Add autoware_ before find-pkg-share.
- Change node pkg="<pkgname>" to autoware_<pkgname>.
Include
- Add autoware folder as necessary and update include statements accordingly.
- Check for impacts on other packages.
Verification Points
- Search find-pkg-share in autoware
- Check README file (especially json schema)
- Pay attention to complex cases like sensor_launch as seen in gnss_poser

Notes for Reviewers

None.

Interface Changes

None.

Effects on System Behavior

All the developers who were using hazard_status_converter needs to modify their code. This is maybe kind of non quick-win task.

Signed-off-by: Junya Sasaki <[email protected]>

github-actions · 2025-01-19T11:28:49Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

…-status-converter

codecov · 2025-01-20T02:43:10Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.45%. Comparing base (9c39d3f) to head (5b22fda).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
...autoware_hazard_status_converter/src/converter.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9971      +/-   ##
==========================================
- Coverage   29.79%   29.45%   -0.34%     
==========================================
  Files        1434     1426       -8     
  Lines      108244   107759     -485     
  Branches    42930    42791     -139     
==========================================
- Hits        32247    31742     -505     
- Misses      72868    72956      +88     
+ Partials     3129     3061      -68

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`29.47% <ø> (-0.33%)`	⬇️	Carriedforward from 0da8d5e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

isamu-takagi · 2025-01-21T08:56:35Z

system/autoware_hazard_status_converter/src/converter.cpp

@@ -1,4 +1,4 @@
-// Copyright 2023 The Autoware Contributors
+// Copyright 2025 The Autoware Contributors


Please keep the copyright year. This is the publication year.

Fixed by this commit

isamu-takagi · 2025-01-21T08:56:43Z

system/autoware_hazard_status_converter/src/converter.hpp

@@ -1,4 +1,4 @@
-// Copyright 2023 The Autoware Contributors
+// Copyright 2025 The Autoware Contributors


Please keep the copyright year. This is the publication year.

Fixed by this commit

…-status-converter Signed-off-by: Junya Sasaki <[email protected]>

…verter' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-hazard-status-converter Signed-off-by: Junya Sasaki <[email protected]>

Signed-off-by: Junya Sasaki <[email protected]>

isamu-takagi

LGTM

SakodaShintaro

I think that the following line needs to be fixed.

autoware.universe/launch/tier4_system_launch/launch/system.launch.xml

Line 103 in 8eed7e9

    
           <include file="$(find-pkg-share hazard_status_converter)/launch/hazard_status_converter.launch.xml"/>

…-status-converter

Signed-off-by: Shintaro Sakoda <[email protected]>

SakodaShintaro

I pushed a necessary change.
0da8d5e

planning_simulator with sample_map
logging_simulator with sample_rosbag
logging_simulator with awsim_gt_data(TIER IV INTERNAL)
e2e_simulator with AWSIM v1.3.1
driving_log_replayer on localization scenario

Signed-off-by: Ryohsuke Mitsudome <[email protected]>

mitsudome-r · 2025-01-24T11:14:03Z

I forgot to attach the evaluator result (TIER IV Internal link):
https://evaluation.ci.tier4.jp/evaluation/reports/53e058e2-47af-559a-974f-6c3520d709b5?project_id=prd_jt

sasakisasaki added 2 commits January 19, 2025 20:24

feat(hazard_status_converter): apply autoware_ prefix

b4a3e1e

Signed-off-by: Junya Sasaki <[email protected]>

rename: hazard_status_converter => autoware_hazard_status_converter

5a88be8

Signed-off-by: Junya Sasaki <[email protected]>

github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Jan 19, 2025

sasakisasaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2025

pre-commit-ci bot and others added 2 commits January 19, 2025 11:31

style(pre-commit): autofix

4d02451

Merge branch 'main' into feat-apply-autoware-prefix-for-system-hazard…

5c8f560

…-status-converter

sasakisasaki marked this pull request as ready for review January 20, 2025 02:35

sasakisasaki requested a review from isamu-takagi as a code owner January 20, 2025 02:35

sasakisasaki requested a review from mitsudome-r January 20, 2025 02:36

isamu-takagi requested changes Jan 21, 2025

View reviewed changes

sasakisasaki and others added 5 commits January 22, 2025 14:36

Merge branch 'main' into feat-apply-autoware-prefix-for-system-hazard…

c006091

…-status-converter Signed-off-by: Junya Sasaki <[email protected]>

Merge branch 'feat-apply-autoware-prefix-for-system-hazard-status-con…

bdbc005

…verter' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-hazard-status-converter Signed-off-by: Junya Sasaki <[email protected]>

bug(autoware_hazard_status_converter): revert wrongly updated copyrights

4244cfa

Signed-off-by: Junya Sasaki <[email protected]>

bug(autoware_hazard_status_converter): fix consistency bugs

44df5c3

Signed-off-by: Junya Sasaki <[email protected]>

style(pre-commit): autofix

19b1306

sasakisasaki requested a review from isamu-takagi January 22, 2025 08:02

isamu-takagi approved these changes Jan 22, 2025

View reviewed changes

SakodaShintaro requested changes Jan 23, 2025

View reviewed changes

SakodaShintaro added 2 commits January 23, 2025 18:16

Merge branch 'main' into feat-apply-autoware-prefix-for-system-hazard…

e22ce34

…-status-converter

Fixed to autoware_hazard_status_converter

0da8d5e

Signed-off-by: Shintaro Sakoda <[email protected]>

SakodaShintaro requested review from ito-san and TetsuKawa as code owners January 23, 2025 09:17

github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 23, 2025

SakodaShintaro approved these changes Jan 23, 2025

View reviewed changes

docs(autoware_hazard_status_converter): update package names in docs

5b22fda

Signed-off-by: Ryohsuke Mitsudome <[email protected]>

mitsudome-r approved these changes Jan 24, 2025

View reviewed changes

mitsudome-r merged commit 1794419 into autowarefoundation:main Jan 24, 2025
34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: apply `autoware_` prefix for `hazard_status_converter` #9971

feat: apply `autoware_` prefix for `hazard_status_converter` #9971

sasakisasaki commented Jan 19, 2025 •

edited

Loading

github-actions bot commented Jan 19, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading

isamu-takagi Jan 21, 2025

sasakisasaki Jan 22, 2025

isamu-takagi Jan 21, 2025

sasakisasaki Jan 22, 2025

isamu-takagi left a comment

SakodaShintaro left a comment

SakodaShintaro left a comment

mitsudome-r commented Jan 24, 2025

		@@ -1,4 +1,4 @@
		// Copyright 2023 The Autoware Contributors
		// Copyright 2025 The Autoware Contributors

feat: apply autoware_ prefix for hazard_status_converter #9971

feat: apply autoware_ prefix for hazard_status_converter #9971

Conversation

sasakisasaki commented Jan 19, 2025 • edited Loading

Description

Related Links

How was this PR tested?

Notes for Reviewers

Interface Changes

Effects on System Behavior

github-actions bot commented Jan 19, 2025 • edited Loading

codecov bot commented Jan 20, 2025 • edited Loading

Codecov Report

isamu-takagi Jan 21, 2025

Choose a reason for hiding this comment

sasakisasaki Jan 22, 2025

Choose a reason for hiding this comment

isamu-takagi Jan 21, 2025

Choose a reason for hiding this comment

sasakisasaki Jan 22, 2025

Choose a reason for hiding this comment

isamu-takagi left a comment

Choose a reason for hiding this comment

SakodaShintaro left a comment

Choose a reason for hiding this comment

SakodaShintaro left a comment

Choose a reason for hiding this comment

mitsudome-r commented Jan 24, 2025

feat: apply `autoware_` prefix for `hazard_status_converter` #9971

feat: apply `autoware_` prefix for `hazard_status_converter` #9971

sasakisasaki commented Jan 19, 2025 •

edited

Loading

github-actions bot commented Jan 19, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading