-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply autoware
prefix for component_state_monitor
and its dependencies
#9961
Conversation
Packages: * component_state_monitor * diagnostic_graph_aggregator * system_diagnostic_monitor * topic_state_monitor Note: * In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. * The changes will follow the Autoware's guideline as below: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder Signed-off-by: Junya Sasaki <[email protected]>
* Based on this rule: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#entire-structure Signed-off-by: Junya Sasaki <[email protected]>
* `component_state_monitor` => `autoware_component_state_monitor` * `diagnostic_graph_aggregator` => `autoware_diagnostic_graph_aggregator` * `system_diagnostic_monitor` => `autoware_system_diagnostic_monitor` * `topic_state_monitor` => `autoware_topic_state_monitor` Signed-off-by: Junya Sasaki <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Junya Sasaki <[email protected]>
…ent-state-monitor-and-its-dependencies Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
…onitor-and-its-dependencies' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-component-state-monitor-and-its-dependencies Signed-off-by: Junya Sasaki <[email protected]>
…ent-state-monitor-and-its-dependencies
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9961 +/- ##
==========================================
+ Coverage 29.77% 29.91% +0.13%
==========================================
Files 1436 1463 +27
Lines 108319 109323 +1004
Branches 42955 43261 +306
==========================================
+ Hits 32254 32703 +449
- Misses 72932 73431 +499
- Partials 3133 3189 +56
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ent-state-monitor-and-its-dependencies
Signed-off-by: Junya Sasaki <[email protected]>
…onitor-and-its-dependencies' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-component-state-monitor-and-its-dependencies Signed-off-by: Junya Sasaki <[email protected]>
…ent-state-monitor-and-its-dependencies
…ent-state-monitor-and-its-dependencies Signed-off-by: Junya Sasaki <[email protected]>
…onitor-and-its-dependencies' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-component-state-monitor-and-its-dependencies Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
…onitor-and-its-dependencies' of https://github.com/sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-component-state-monitor-and-its-dependencies
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ent-state-monitor-and-its-dependencies
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
…ining files Signed-off-by: Ryohsuke Mitsudome <[email protected]>
… package name in docs Signed-off-by: Ryohsuke Mitsudome <[email protected]>
…ge name in docs Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
…-for-system-component-state-monitor-and-its-dependencies Signed-off-by: Shintaro Sakoda <[email protected]>
…-for-system-component-state-monitor-and-its-dependencies Signed-off-by: Shintaro Sakoda <[email protected]>
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_
prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.This has to be merged with:
Related Links
How was this PR tested?
Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Evaluator
https://evaluation.ci.tier4.jp/evaluation/reports/c4be7df3-ded3-5c8b-83b7-897ace874a8c?project_id=prd_jt
Executed Commands (which succeeded)
Directory Name
autoware_
as a prefix to the directory name.packages.xml
autoware_
to thename
element.CMakeLists.txt
project
name toautoware_***
.autoware::
toPLUGIN
.Header Files (.hpp)
#ifndef
guards withAUTOWARE__
.autoware::
tonamespace
.Source Files (.cpp)
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.Launch Files
autoware_
beforefind-pkg-share
.node pkg="<pkgname>"
toautoware_<pkgname>
.Include
autoware
folder as necessary and update include statements accordingly.Verification Points
find-pkg-share
in autowaresensor_launch
as seen ingnss_poser
Notes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
component_state_monitor
needs to modify their code. This is maybe kind of non quick-win task.