Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: operation mode debug panel #8933

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Sep 21, 2024

Description

The legacy state panel is used to debug the operation mode.
Since it would be confusing to have a panel with the same function, I extracted that part.
Also, since it will be used as a panel dedicated to debugging, the following changes have been made:

  • The mode change button can be used even if is_mode_*_available is false.
  • The mode change button can be used even if it is the same as the current mode.
  • Display raw value when unknown mode

Related links

How was this PR tested?

  1. Run planning simulation
  2. Add OperationModeDebugPanel from rviz menu
  3. Change to drive mode and stop mode.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 21, 2024
Copy link

github-actions bot commented Sep 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi self-assigned this Sep 21, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi force-pushed the feat/operatoin-mode-debug-panel branch from c3c2bca to 68ed543 Compare September 22, 2024 06:52
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 22, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
@xmfcx
Copy link
Contributor

xmfcx commented Sep 23, 2024

@isamu-takagi -san, thanks for the consideration.

Could you also rename the panel to operation_mode_debug_panel to avoid confusion?

@isamu-takagi isamu-takagi marked this pull request as ready for review September 24, 2024 05:00
@xmfcx xmfcx changed the title feat: operation mode panel feat: operation mode debug panel Sep 24, 2024
@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Project coverage is 29.77%. Comparing base (40aff9f) to head (1fc096d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...api_rviz_plugin/src/operation_mode_debug_panel.cpp 0.00% 106 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8933      +/-   ##
==========================================
- Coverage   29.78%   29.77%   -0.01%     
==========================================
  Files        1436     1438       +2     
  Lines      108310   108429     +119     
  Branches    42956    42959       +3     
==========================================
+ Hits        32256    32285      +29     
- Misses      72922    73007      +85     
- Partials     3132     3137       +5     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.80% <ø> (+0.02%) ⬆️ Carriedforward from ea214c5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Nov 23, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 23, 2024
@xmfcx xmfcx self-requested a review December 6, 2024 00:53
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 6, 2024
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 24, 2024
@isamu-takagi
Copy link
Contributor Author

@h-ohta @kosuke55 Could you review this PR?

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

image

It is now clear, it works as it should. I didn't test all functionality but if anyone finds it, we can revert it. Thanks @isamu-takagi -san!

@xmfcx xmfcx merged commit 0a708da into autowarefoundation:main Jan 27, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants