-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: operation mode debug panel #8933
feat: operation mode debug panel #8933
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Takagi, Isamu <[email protected]>
c3c2bca
to
68ed543
Compare
Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi -san, thanks for the consideration. Could you also rename the panel to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8933 +/- ##
==========================================
- Coverage 29.78% 29.77% -0.01%
==========================================
Files 1436 1438 +2
Lines 108310 108429 +119
Branches 42956 42959 +3
==========================================
+ Hits 32256 32285 +29
- Misses 72922 73007 +85
- Partials 3132 3137 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: Takagi, Isamu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now clear, it works as it should. I didn't test all functionality but if anyone finds it, we can revert it. Thanks @isamu-takagi -san!
Description
The legacy state panel is used to debug the operation mode.
Since it would be confusing to have a panel with the same function, I extracted that part.
Also, since it will be used as a panel dedicated to debugging, the following changes have been made:
is_mode_*_available
is false.Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.