chore(freespace_planning_algorithms): update for A* python wrapper #8890
Conversation
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
TakumIto
force-pushed
the
feat/astar_wrapper_distance_function
branch
3 times, most recently
from
333efc0 to
1e25b48
Compare
TakumIto
requested review from
kosuke55,
TakaHoribe and
takayuki5168
as code owners
| double getDistanceToObstacle(const std::string & pose_byte) | ||
| { | ||
| rclcpp::SerializedMessage serialized_msg; | ||
| static constexpr size_t message_header_length = 8u; |
There was a problem hiding this comment.
how to know this value 8u?
There was a problem hiding this comment.
I imitated the code of another feature.
https://github.com/autowarefoundation/autoware_common/blob/7c55915cb435c17f24f78dd9b9f28fa269609671/tmp/lanelet2_extension_python/src/utility.cpp#L136
It uses the same header length 8u for all messages. But I'm sorry, I have no idea how it has been decided.
Signed-off-by: Takumi Ito <[email protected]>
Signed-off-by: Takumi Ito <[email protected]>
Signed-off-by: Takumi Ito <[email protected]>
kosuke55
force-pushed
the
feat/astar_wrapper_distance_function
branch
from
521f76e to
d2226de
Compare
kosuke55
added
the
run:build-and-test-differential
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
@kosuke55 Is this OK to merge? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8890 +/- ##
==========================================
- Coverage 28.30% 28.29% -0.01%
==========================================
Files 1484 1485 +1
Lines 111090 111118 +28
Branches 43151 43152 +1
==========================================
+ Hits 31441 31442 +1
- Misses 76631 76659 +28
+ Partials 3018 3017 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Update for A* python wrapper to use the getDistanceToObstacle() function.
Related links
This PR is initially prepared for A* parameter tuning tool autoware_tools PR#120. But, not only for it but also for other applications using python wrapper.
How was this PR tested?
Evaluator: https://evaluation.tier4.jp/evaluation/reports/733ee4d0-e5fc-5308-8520-fdbaf61526f8?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.