-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_perception_launch): add missing arg use_multi_channel_tracker_merger #7705
Merged
technolojin
merged 3 commits into
autowarefoundation:main
from
technolojin:fix/perception-tracker-launch-missing-arg
Jun 26, 2024
Merged
feat(tier4_perception_launch): add missing arg use_multi_channel_tracker_merger #7705
technolojin
merged 3 commits into
autowarefoundation:main
from
technolojin:fix/perception-tracker-launch-missing-arg
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker_merger Signed-off-by: Taekjin LEE <[email protected]>
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Jun 26, 2024
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
technolojin
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 26, 2024
yukkysaito
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YoshiRi
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds the `use_multi_channel_tracker_merger` argument to the simulator launch file. The argument is set to `false` by default. This change enables the use of the multi-channel tracker merger in the simulator. Signed-off-by: Taekjin LEE <[email protected]>
technolojin
requested review from
KeisukeShima,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
June 26, 2024 07:42
tkimura4
approved these changes
Jun 26, 2024
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…ker_merger (autowarefoundation#7705) * feat(tier4_perception_launch): add missing arg use_multi_channel_tracker_merger Signed-off-by: Taekjin LEE <[email protected]> * feat: add use_multi_channel_tracker_merger argument to simulator launch This commit adds the `use_multi_channel_tracker_merger` argument to the simulator launch file. The argument is set to `false` by default. This change enables the use of the multi-channel tracker merger in the simulator. Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…ker_merger (autowarefoundation#7705) * feat(tier4_perception_launch): add missing arg use_multi_channel_tracker_merger Signed-off-by: Taekjin LEE <[email protected]> * feat: add use_multi_channel_tracker_merger argument to simulator launch This commit adds the `use_multi_channel_tracker_merger` argument to the simulator launch file. The argument is set to `false` by default. This change enables the use of the multi-channel tracker merger in the simulator. Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…ker_merger (autowarefoundation#7705) * feat(tier4_perception_launch): add missing arg use_multi_channel_tracker_merger Signed-off-by: Taekjin LEE <[email protected]> * feat: add use_multi_channel_tracker_merger argument to simulator launch This commit adds the `use_multi_channel_tracker_merger` argument to the simulator launch file. The argument is set to `false` by default. This change enables the use of the multi-channel tracker merger in the simulator. Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: palas21 <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…ker_merger (autowarefoundation#7705) * feat(tier4_perception_launch): add missing arg use_multi_channel_tracker_merger Signed-off-by: Taekjin LEE <[email protected]> * feat: add use_multi_channel_tracker_merger argument to simulator launch This commit adds the `use_multi_channel_tracker_merger` argument to the simulator launch file. The argument is set to `false` by default. This change enables the use of the multi-channel tracker merger in the simulator. Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ker_merger (#7705) * feat(tier4_perception_launch): add missing arg use_multi_channel_tracker_merger Signed-off-by: Taekjin LEE <[email protected]> * feat: add use_multi_channel_tracker_merger argument to simulator launch This commit adds the `use_multi_channel_tracker_merger` argument to the simulator launch file. The argument is set to `false` by default. This change enables the use of the multi-channel tracker merger in the simulator. Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add missing arg use_multi_channel_tracker_merger to fix the following launch error
Related links
#7459
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.