-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multi_object_tracker): input stream timimg functions #7127
Merged
technolojin
merged 3 commits into
autowarefoundation:main
from
technolojin:fix/mot-input-stream-timings
May 29, 2024
Merged
fix(multi_object_tracker): input stream timimg functions #7127
technolojin
merged 3 commits into
autowarefoundation:main
from
technolojin:fix/mot-input-stream-timings
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
label
May 27, 2024
7 tasks
technolojin
changed the title
fix (multi_object_tracker): input stream timimg functions
fix(multi_object_tracker): input stream timimg functions
May 27, 2024
technolojin
force-pushed
the
fix/mot-input-stream-timings
branch
from
May 27, 2024 07:44
edab576
to
b6e9a6b
Compare
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
technolojin
force-pushed
the
fix/mot-input-stream-timings
branch
from
May 28, 2024 03:02
b6e9a6b
to
94bdca4
Compare
yukkysaito
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
technolojin
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 29, 2024
@yukkysaito @technolojin still died
|
@wep21 Thanks for the report. @technolojin , may I ask you to analyze the bug? |
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ndation#7127) * fix: rename to latest_exported_object_time_ Signed-off-by: Taekjin LEE <[email protected]> * fix: add time range checks Signed-off-by: Taekjin LEE <[email protected]> * chore: add comments, refactoring Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
4 tasks
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…ndation#7127) * fix: rename to latest_exported_object_time_ Signed-off-by: Taekjin LEE <[email protected]> * fix: add time range checks Signed-off-by: Taekjin LEE <[email protected]> * chore: add comments, refactoring Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* fix: rename to latest_exported_object_time_ Signed-off-by: Taekjin LEE <[email protected]> * fix: add time range checks Signed-off-by: Taekjin LEE <[email protected]> * chore: add comments, refactoring Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The input stream checked the object time interval inputs (object_latest_time and object_oldest_time) whether the latest time is later than the oldest time.
There was a report that the reversed timing settings (object_latest_time is older than object_oldest_time) was observed and the assertion stop the node, in the planning simulation environment.
#6820 (comment)
InputManager::getObjectTimeInterval
Eliminated possibility to ouput the time interval settings (object_latest_time and object_oldest_time) in wrong order.
latest_object_time_ (renamed to latest_exported_object_time_)
Initializing this value to
now
(time at the initialization) can cause the reversed times.This value will be initialized to a bit older than the initialization time.
The value was renamed to avoid confusion.
InputStream::getObjectsOlderThan
It checks the settings, but just warn (not assert) and return.
Tests performed
Regular test : TIER IV INTERNAL
Effects on system behavior
Not applicable.
Interface changes
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.