Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): input stream timimg functions #7127

Merged

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented May 27, 2024

Description

The input stream checked the object time interval inputs (object_latest_time and object_oldest_time) whether the latest time is later than the oldest time.
There was a report that the reversed timing settings (object_latest_time is older than object_oldest_time) was observed and the assertion stop the node, in the planning simulation environment.
#6820 (comment)

  1. InputManager::getObjectTimeInterval
    Eliminated possibility to ouput the time interval settings (object_latest_time and object_oldest_time) in wrong order.

  2. latest_object_time_ (renamed to latest_exported_object_time_)
    Initializing this value to now (time at the initialization) can cause the reversed times.
    This value will be initialized to a bit older than the initialization time.
    The value was renamed to avoid confusion.

  3. InputStream::getObjectsOlderThan
    It checks the settings, but just warn (not assert) and return.

Tests performed

Regular test : TIER IV INTERNAL

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 27, 2024
@technolojin technolojin changed the title fix (multi_object_tracker): input stream timimg functions fix(multi_object_tracker): input stream timimg functions May 27, 2024
@technolojin technolojin force-pushed the fix/mot-input-stream-timings branch from edab576 to b6e9a6b Compare May 27, 2024 07:44
@technolojin technolojin self-assigned this May 27, 2024
@technolojin technolojin force-pushed the fix/mot-input-stream-timings branch from b6e9a6b to 94bdca4 Compare May 28, 2024 03:02
@technolojin technolojin marked this pull request as ready for review May 29, 2024 00:13
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin enabled auto-merge (squash) May 29, 2024 07:04
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 29, 2024
@technolojin technolojin merged commit 8237b7d into autowarefoundation:main May 29, 2024
31 of 33 checks passed
@wep21
Copy link
Contributor

wep21 commented May 30, 2024

@yukkysaito @technolojin still died

[multi_object_tracker_node-49] *** Aborted at 1717082878 (unix time) try "date -d @1717082878" if you are using GNU date ***
[multi_object_tracker_node-49] PC: @                0x0 (unknown)
[multi_object_tracker_node-49] *** SIGSEGV (@0x20) received by PID 461172 (TID 0x7df1e7c2f8c0) from PID 32; stack trace: ***
[multi_object_tracker_node-49]     @     0x7df1e548a206 (unknown)
[multi_object_tracker_node-49]     @     0x7df1e7a45320 (unknown)
[multi_object_tracker_node-49]     @     0x7df1e4932f0f TrackerObjectDebugger::process()
[multi_object_tracker_node-49]     @     0x7df1e48f8e08 TrackerDebugger::publishObjectsMarkers()
[multi_object_tracker_node-49]     @     0x7df1e48881e6 multi_object_tracker::MultiObjectTracker::publish()
[multi_object_tracker_node-49]     @     0x7df1e4887e5e multi_object_tracker::MultiObjectTracker::checkAndPublish()
[multi_object_tracker_node-49]     @     0x7df1e48875cc multi_object_tracker::MultiObjectTracker::onTimer()
[multi_object_tracker_node-49]     @     0x7df1e48cf76d std::__invoke_impl<>()
[multi_object_tracker_node-49]     @     0x7df1e48c98e9 std::__invoke<>()
[multi_object_tracker_node-49]     @     0x7df1e48c449b _ZNSt5_BindIFMN20multi_object_tracker18MultiObjectTrackerEFvvEPS1_EE6__callIvJEJLm0EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
[multi_object_tracker_node-49]     @     0x7df1e48bdab5 std::_Bind<>::operator()<>()
[multi_object_tracker_node-49]     @     0x7df1e48edabc rclcpp::GenericTimer<>::execute_callback_delegate<>()
[multi_object_tracker_node-49]     @     0x7df1e48ea877 rclcpp::GenericTimer<>::execute_callback()
[multi_object_tracker_node-49]     @     0x7df1e8307a51 rclcpp::Executor::execute_any_executable()
[multi_object_tracker_node-49]     @     0x7df1e8319234 rclcpp::executors::SingleThreadedExecutor::spin()
[multi_object_tracker_node-49]     @     0x65224930e45c main
[multi_object_tracker_node-49]     @     0x7df1e7a2a1ca (unknown)
[multi_object_tracker_node-49]     @     0x7df1e7a2a28b __libc_start_main
[multi_object_tracker_node-49]     @     0x65224930dac5 _start

@yukkysaito
Copy link
Contributor

@wep21 Thanks for the report.

@technolojin , may I ask you to analyze the bug?

karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ndation#7127)

* fix: rename to latest_exported_object_time_

Signed-off-by: Taekjin LEE <[email protected]>

* fix: add time range checks

Signed-off-by: Taekjin LEE <[email protected]>

* chore: add comments, refactoring

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin
Copy link
Contributor Author

technolojin commented Jun 7, 2024

@wep21 Thank you for your report.
The message indicates seems to be an another issue.
However I couldn't reproduce this issue from my environment.

Based on the error message, I created a trial of the bug fix. #7347
Can you test this modification?

a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…ndation#7127)

* fix: rename to latest_exported_object_time_

Signed-off-by: Taekjin LEE <[email protected]>

* fix: add time range checks

Signed-off-by: Taekjin LEE <[email protected]>

* chore: add comments, refactoring

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* fix: rename to latest_exported_object_time_

Signed-off-by: Taekjin LEE <[email protected]>

* fix: add time range checks

Signed-off-by: Taekjin LEE <[email protected]>

* chore: add comments, refactoring

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin deleted the fix/mot-input-stream-timings branch July 26, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants