Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): smooth ndt map update #6394

Merged
merged 18 commits into from
Feb 20, 2024

Merge branch 'main' into feature/smooth_ndt_map_update

3e86814
Select commit
Loading
Failed to load commit list.
Merged

feat(ndt_scan_matcher): smooth ndt map update #6394

Merge branch 'main' into feature/smooth_ndt_map_update
3e86814
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 20, 2024 in 52s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method map_update_module.cpp: MapUpdateModule::update_ndt

Annotations

Check warning on line 170 in localization/ndt_scan_matcher/src/map_update_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

MapUpdateModule::update_ndt has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis