Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_map_height_fitter): find PCL package after autoware_package() is called #10070

Conversation

mitsudome-r
Copy link
Member

Description

This package fails to build with the autoware_utils 1.1.0.
(This package depends on autoware_utils via autoware_lanelet2_extension)

Since autoware_utils is now depending on pcl as well, it overwrites some of PCL related CMAKE variables.
In order to only import intended modules, PCL should be included after calling autoware_package().

Related links

How was this PR tested?

  • checkout 1.1.0 for autoware_utils
  • build autoware

I have tested locally that the build passes without an error.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.32%. Comparing base (b3c69b4) to head (a527409).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10070      +/-   ##
==========================================
- Coverage   28.33%   28.32%   -0.02%     
==========================================
  Files        1485     1489       +4     
  Lines      111092   111141      +49     
  Branches    43152    43153       +1     
==========================================
  Hits        31483    31483              
- Misses      76588    76637      +49     
  Partials     3021     3021              
Flag Coverage Δ *Carryforward flag
differential 0.15% <ø> (?)
total 28.33% <ø> (ø) Carriedforward from b3c69b4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit 2d3928d into autowarefoundation:main Feb 5, 2025
45 of 46 checks passed
@mitsudome-r mitsudome-r deleted the fix-autoware-map-height-fitter branch February 5, 2025 03:52
youtalk pushed a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants