Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): check usage of bus_stop_area by goal_pose #10041

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 29, 2025

Description

enable bus_stop_area goal search and bezier search if use_bus_stop_area = true and the goal position is inside a bus stop area

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 30, 2025
@soblin soblin force-pushed the fix/goal-planner/bus-stop-area-usage-check branch from c9a55b7 to bebda92 Compare January 30, 2025 09:02
Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin enabled auto-merge (squash) January 30, 2025 09:05
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 28.85%. Comparing base (461dbc1) to head (9eb497e).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 14 Missing and 1 partial ⚠️
.../behavior_path_goal_planner_module/thread_data.hpp 0.00% 2 Missing ⚠️
...or_path_goal_planner_module/goal_searcher_base.hpp 0.00% 1 Missing ⚠️
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10041      +/-   ##
==========================================
- Coverage   29.21%   28.85%   -0.37%     
==========================================
  Files        1439     1444       +5     
  Lines      108115   109092     +977     
  Branches    42638    43161     +523     
==========================================
- Hits        31588    31477     -111     
- Misses      73485    74525    +1040     
- Partials     3042     3090      +48     
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 29.15% <0.00%> (-0.07%) ⬇️ Carriedforward from bebda92

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 2c53d5f into autowarefoundation:main Jan 30, 2025
33 of 34 checks passed
@soblin soblin deleted the fix/goal-planner/bus-stop-area-usage-check branch January 30, 2025 09:49
yhisaki pushed a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2025
SakodaShintaro pushed a commit to tier4/autoware.universe that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants