Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_vehicle_info_utils): porting from universe to core #170

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JianKangEgon
Copy link

Description

We are porting autoware_vehicle_info_utils to autoware.core, and this PR adds the package to core.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@JianKangEgon
Copy link
Author

This pr depends on the new ported package "autoware_utils": autowarefoundation/autoware_utils#23

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to modify the file paths to include/autoware/vehicle_info_utils according to this guideline.
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#exporting-headers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI Kondo san @youtalk
We have revised the pr according to your comments

Have a nice day!

心刚

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 55.44554% with 45 lines in your changes missing coverage. Please review.

Project coverage is 70.74%. Comparing base (4cb18f5) to head (620d66a).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...n/autoware_vehicle_info_utils/src/vehicle_info.cpp 54.34% 18 Missing and 3 partials ⚠️
...ehicle_info_utils/test/test_vehicle_info_utils.cpp 40.62% 0 Missing and 19 partials ⚠️
...ware_vehicle_info_utils/src/vehicle_info_utils.cpp 77.27% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   78.75%   70.74%   -8.01%     
==========================================
  Files          11       15       +4     
  Lines         193      294     +101     
  Branches       73      129      +56     
==========================================
+ Hits          152      208      +56     
- Misses         11       33      +22     
- Partials       30       53      +23     
Flag Coverage Δ *Carryforward flag
differential 55.44% <55.44%> (?)
total 78.75% <ø> (ø) Carriedforward from 4cb18f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

4 participants